You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/13 07:23:50 UTC

[GitHub] [spark] LuciferYang removed a comment on pull request #35493: [SPAPRK-38192][CORE][TESTS] Use `try-with-resources` in `Level/RocksDBSuite.java`

LuciferYang removed a comment on pull request #35493:
URL: https://github.com/apache/spark/pull/35493#issuecomment-1037881439


   > At the same time, in order to verify whether `LevelDB` will cause VM crash because `DBIterator ` is not closed, I try to delete some code related to resource release [here](https://github.com/apache/spark/pull/35497) and wait for the test results.
   
   @dongjoon-hyun It seems that even if delete the registration process of `iteratorTracker` and delete the `finalize()` method in `LevelDBIterator` to not close `LevelDBIterator` at all, it will not cause VM crash on X86 platform, although it will certainly cause resource leak


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org