You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Sunil Govindan (JIRA)" <ji...@apache.org> on 2019/03/01 15:00:00 UTC
[jira] [Comment Edited] (YARN-9138) Test error handling of
nvidia-smi binary execution of GpuDiscoverer
[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781705#comment-16781705 ]
Sunil Govindan edited comment on YARN-9138 at 3/1/19 2:59 PM:
--------------------------------------------------------------
Hi [~snemeth]
Few comments:
# Could GPU_SCRIPT_REFERENCE import could be avoided in GpuDiscoverer
# In getGpuDeviceInformation, I think "final String msg" can be avoided across.
# Rather than testSubject, could we say as testPlugin
# IN test cases, could we add a test case which covers a case where partial NvidiaSmiScript o/p is only got back?
Thanks
was (Author: sunilg):
Hi [~snemeth]
Few comments:
# Could GPU_SCRIPT_REFERENCE import could be avoided in GpuDiscoverer
# In getGpuDeviceInformation, I dont think "final String msg" can be avoided across.
# Rather than testSubject, could we say as testPlugin
# IN test cases, could we add a test case which covers a case where partial NvidiaSmiScript o/p is only got back?
Thanks
> Test error handling of nvidia-smi binary execution of GpuDiscoverer
> -------------------------------------------------------------------
>
> Key: YARN-9138
> URL: https://issues.apache.org/jira/browse/YARN-9138
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-9138.001.patch, YARN-9138.002.patch, YARN-9138.003.patch, YARN-9138.004.patch, YARN-9138.005.patch
>
>
> The code that executes nvidia-smi (doing GPU device auto-discovery) don't have much test coverage.
> This patch adds tests to this part of the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org