You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Bruno Cadonna (Jira)" <ji...@apache.org> on 2023/10/17 14:55:00 UTC

[jira] [Updated] (KAFKA-15624) Reconsider synchronisation of methods in RocksDBStore

     [ https://issues.apache.org/jira/browse/KAFKA-15624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Cadonna updated KAFKA-15624:
----------------------------------
    Labels:   (was: streams)

> Reconsider synchronisation of methods in RocksDBStore
> -----------------------------------------------------
>
>                 Key: KAFKA-15624
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15624
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Bruno Cadonna
>            Priority: Major
>
> The code in {{RocksDBStore}} evolved over time. We should reconsider the synchronization of the methods in RocksDBStore. Maybe some synchronizations are not needed anymore or can be improved. 
> The synchronization of the methods is inconsistent. For example, {{putAll()}} is not synchronized whereas {{put()}} is synchronized. That could be because once {{putAll()}} was a loop over multiple calls to {{put()}}. Additionally, we should reconsider how we validate whether the store is open since that seems to be the main reason why we synchronize methods.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)