You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/04/09 14:10:50 UTC
[GitHub] flink pull request: [FLINK-1847] Changes collect to return a Seq[T...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/583
[FLINK-1847] Changes collect to return a Seq[T] and adds parentheses
Changes the return type of Scala API's collect method to Seq[T] and adds parentheses to collect and count methods.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixScalaCollect
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/583.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #583
----
commit cf1b2e3da4e9a9ded929a73d2ecce2fb4046b778
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-04-09T10:26:53Z
[FLINK-1847] [Scala API] Changes the return type of Scala API's collect method to Seq[T] and adds parentheses to collect and count methods.
[FLINK-1847] [Scala API] Updates existing test cases using Scala API's collect/count method.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1847] Changes collect to return a Seq[T...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/583
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1847] Changes collect to return a Seq[T...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/583#issuecomment-91330315
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1847] Changes collect to return a Seq[T...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/583#issuecomment-91326117
+1 looks good and pretty important, since this would be API breaking to change after 0.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---