You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/09/12 05:11:58 UTC
[GitHub] [dubbo-go-pixiu-samples] ma642 opened a new pull request, #2: The sample for PR https://github.com/apache/dubbo-go-pixiu/pull/446 (deploy pixiu as dubbo service egress gateway in k8s istio)
ma642 opened a new pull request, #2:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/2
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
The sample for PR https://github.com/apache/dubbo-go-pixiu/pull/446 (deploy pixiu as dubbo service egress gateway in k8s istio)
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**: NONE
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu-samples] ma642 closed pull request #2: The sample for PR https://github.com/apache/dubbo-go-pixiu/pull/446 (deploy pixiu as dubbo service egress gateway in k8s istio)
Posted by GitBox <gi...@apache.org>.
ma642 closed pull request #2: The sample for PR https://github.com/apache/dubbo-go-pixiu/pull/446 (deploy pixiu as dubbo service egress gateway in k8s istio)
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu-samples] github-actions[bot] commented on a diff in pull request #2: The sample for PR https://github.com/apache/dubbo-go-pixiu/pull/446 (deploy pixiu as dubbo service egress gateway in k8s istio)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #2:
URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/2#discussion_r967991323
##########
xds/dubbo-go-istio/server/chart/nacos_env/templates/_helpers.tpl:
##########
@@ -0,0 +1,62 @@
+{{/*
Review Comment:
```suggestion
{*
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
*}
{{/*
```
<!-- license-eye hidden identification -->
##########
xds/dubbo-go-istio/server/chart/app/templates/_helpers.tpl:
##########
@@ -0,0 +1,62 @@
+{{/*
Review Comment:
```suggestion
{*
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
*}
{{/*
```
<!-- license-eye hidden identification -->
##########
xds/dubbo-go-istio/server/chart/pixiu-gateway/templates/_helpers.tpl:
##########
@@ -0,0 +1,62 @@
+{{/*
Review Comment:
```suggestion
{*
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
*}
{{/*
```
<!-- license-eye hidden identification -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org