[GitHub] [opennlp] kinow commented on a diff in pull request #476: OPENNLP-1358 - Failing tests on Windows 11 and Java 17

[GitBox <gi...@apache.org>]

kinow commented on code in PR #476:
URL: https://github.com/apache/opennlp/pull/476#discussion_r1059526576


##########
.github/workflows/maven.yml:
##########
@@ -23,8 +23,8 @@ jobs:
     continue-on-error: ${{ matrix.experimental }}
     strategy:
       matrix:
-        os: [ubuntu-latest]
-        java: [ 11 ]
+        os: [ubuntu-latest, windows-latest]

Review Comment:
   I read the title of the PR and was going to suggest to enable the GH Actions for Windows, but glad you've already enabled it! Thanks!



##########
opennlp-tools/src/test/java/opennlp/tools/AbstractTempDirTest.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+
+// Workaround for https://github.com/junit-team/junit5/issues/2811 - we cannot use @TempDir atm.

Review Comment:
   Add a `TODO`? So we don't forget?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org