[GitHub] [ignite] petrov-mg commented on a diff in pull request #10831: IGNITE-18830 Optimize log in GridQueryProcessor

["petrov-mg (via GitHub)" <gi...@apache.org>]

petrov-mg commented on code in PR #10831:
URL: https://github.com/apache/ignite/pull/10831#discussion_r1264099980


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/GridQueryProcessor.java:
##########
@@ -2637,10 +2637,13 @@ private IgniteInternalFuture<?> rebuildIndexesFromHash0(
             idxFut.listen(fut -> {
                 Throwable err = fut.error();
 
-                if (isNull(err) && log.isInfoEnabled())
-                    log.info("Finished indexes rebuilding for cache " + cacheInfo);
-                else if (!(err instanceof NodeStoppingException))
+                if (isNull(err)) {
+                    if (log.isInfoEnabled())
+                        log.info("Finished indexes rebuilding for cache " + cacheInfo);
+                }
+                else if (!(err instanceof NodeStoppingException)) {

Review Comment:
   Please remove the braces for the one-liner `else if` statement. This is part of the coding guideline we follow.
   
   Take a look at [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-BracesandIndentation) for more details.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org