You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Alex Newman <ne...@cloudera.com> on 2010/07/23 01:34:49 UTC
Review Request: More log cleanup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/359/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
In the same spirit as my previous submission, i just noticed some small things that could be cleaned up.
Diffs
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java b5a3b8f
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java c1ff9f2
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogActionsListener.java 776d78c
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java 9eae4b4
Diff: http://review.hbase.org/r/359/diff
Testing
-------
Ran on my local hudson.
Thanks,
Alex
Re: Review Request: More log cleanup
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/359/#review530
-----------------------------------------------------------
Ship it!
+1 Let me commit. In future, name your patches other than '1' -- name it for issue? Thanks Alex.
- stack
On 2010-07-22 16:43:24, Alex Newman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/359/
> -----------------------------------------------------------
>
> (Updated 2010-07-22 16:43:24)
>
>
> Review request for hbase.
>
>
> Summary
> -------
>
> In the same spirit as my previous submission, i just noticed some small things that could be cleaned up.
>
>
> This addresses bug HBASE-2868.
> http://issues.apache.org/jira/browse/HBASE-2868
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/master/HMaster.java b5a3b8f
> src/main/java/org/apache/hadoop/hbase/regionserver/Store.java c1ff9f2
> src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogActionsListener.java 776d78c
> src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java 9eae4b4
>
> Diff: http://review.cloudera.org/r/359/diff
>
>
> Testing
> -------
>
> Ran on my local hudson.
>
>
> Thanks,
>
> Alex
>
>
Re: Review Request: More log cleanup
Posted by Alex Newman <ne...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/359/
-----------------------------------------------------------
(Updated 2010-08-10 19:09:07.744972)
Review request for hbase and stack.
Changes
-------
Updated. we had a race messing with this test. I ran it on hudson with no problems.
Summary
-------
In the same spirit as my previous submission, i just noticed some small things that could be cleaned up.
This addresses bug HBASE-2868.
http://issues.apache.org/jira/browse/HBASE-2868
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 9593286
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java 9eae4b4
Diff: http://review.cloudera.org/r/359/diff
Testing
-------
Ran on my local hudson.
Thanks,
Alex
Re: Review Request: More log cleanup
Posted by Alex Newman <ne...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/359/
-----------------------------------------------------------
(Updated 2010-07-22 16:43:24.600907)
Review request for hbase.
Changes
-------
HBASE-2868
Summary
-------
In the same spirit as my previous submission, i just noticed some small things that could be cleaned up.
This addresses bug HBASE-2868.
http://issues.apache.org/jira/browse/HBASE-2868
Diffs
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java b5a3b8f
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java c1ff9f2
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogActionsListener.java 776d78c
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java 9eae4b4
Diff: http://review.hbase.org/r/359/diff
Testing
-------
Ran on my local hudson.
Thanks,
Alex