You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/17 15:00:42 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #1934: Stop recovery if tablet is being deleted
milleruntime opened a new pull request #1934:
URL: https://github.com/apache/accumulo/pull/1934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #1934: Stop recovery if tablet is being deleted
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #1934:
URL: https://github.com/apache/accumulo/pull/1934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1934: Stop recovery if tablet is being deleted
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1934:
URL: https://github.com/apache/accumulo/pull/1934#discussion_r578042249
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
##########
@@ -340,7 +340,7 @@ public Tablet(final TabletServer tabletServer, final KeyExtent extent,
tabletMemory = new TabletMemory(this);
- if (!logEntries.isEmpty()) {
+ if (!logEntries.isEmpty() && !isBeingDeleted()) {
Review comment:
It's not clear without reading a bunch of code what thy this block is being skipped under these circumstances. A comment would help. Is this change just to avoid attempting WAL recovery on a table being deleted, if such a tablet is being loaded?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1934: Stop recovery if tablet is being deleted
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1934:
URL: https://github.com/apache/accumulo/pull/1934#discussion_r578319647
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
##########
@@ -340,7 +340,7 @@ public Tablet(final TabletServer tabletServer, final KeyExtent extent,
tabletMemory = new TabletMemory(this);
- if (!logEntries.isEmpty()) {
+ if (!logEntries.isEmpty() && !isBeingDeleted()) {
Review comment:
I can add a comment.
> Is this change just to avoid attempting WAL recovery on a table being deleted, if such a tablet is being loaded?
Exactly. This is one optimization of least resistance for deletes during a tablet load. I really didn't want to try and short circuit the Tablet loading and risk breaking something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org