[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1414: fix: check delete successfully to ensure every delete option finished

[GitBox <gi...@apache.org>]

juzhiyuan commented on a change in pull request #1414:
URL: https://github.com/apache/apisix-dashboard/pull/1414#discussion_r568275012



##########
File path: web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
##########
@@ -63,16 +65,18 @@ context('Create and Delete Plugin List', () => {
 
   it('should delete plugin list', () => {
     cy.visit('/plugin/list');
-    cy.get(domSelector.refresh).click();
+    cy.get('.ant-btn-dangerous').should('exist');
+
     cy.get(domSelector.tableCell, { timeout }).should('exist').then(function (rows) {
       [...rows].forEach((row) => {
         const name = row.innerText;
-        const cases = this.cases[name] || [];

Review comment:
       We may have a fallback for those plugins that don't have valid or invalid data cases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org