[jira] [Commented] (LUCENE-5826) Support proper hunspell case handling and related options

["Ryan Ernst (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063799#comment-14063799 ] 

Ryan Ernst commented on LUCENE-5826:
------------------------------------

Looks good.  A couple minor comments.

* Can the TODO around line 176 of Stemmer.java be removed?
* {{stem()}} is pretty long.  Can the block that computes {{compatible}} be moved out? It is almost exactly the same for the prefix and suffix loops?

> Support proper hunspell case handling and related options
> ---------------------------------------------------------
>
>                 Key: LUCENE-5826
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5826
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>         Attachments: LUCENE-5826.patch
>
>
> When ignoreCase=false, we should accept title-cased/upper-cased forms just like hunspell -m. Furthermore there are some options around this:
> * LANG: can turn on alternate casing for turkish/azeri
> * KEEPCASE: can prevent acceptance of title/upper cased forms for words
> While we are here setting up the same logic anyway, add support for similar  options:
> * NEEDAFFIX/PSEUDOROOT: form is invalid without being affixed
> * ONLYINCOMPOUND: form/affixes only make sense inside compounds.
> This stuff is unrelated to the ignoreCase=true option. If you use that option though, it does use correct alternate casing for tr_TR/az_AZ now though.
> I didn't yet implement CHECKSHARPS because it seems more complicated, I have to figure out what the logic there should be first.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org