[jira] Updated: (WW-2361) the default request charEncoding always used.

["Don Brown (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/struts/browse/WW-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-2361:
--------------------------

    Fix Version/s:     (was: 2.1.1)
                   2.1.x

Hmm...I'm not sure that the request encoding should always be used.  Could that cause any problems for existing applications?

> the default request charEncoding always used.
> ---------------------------------------------
>
>                 Key: WW-2361
>                 URL: https://issues.apache.org/struts/browse/WW-2361
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.0.11
>            Reporter: Avatar Zhang
>             Fix For: 2.1.x
>
>
> // SUGGESTION
> Index: Dispatcher.java
> ===================================================================
> --- Dispatcher.java	(revision 602010)
> +++ Dispatcher.java	(working copy)
> @@ -620,10 +620,16 @@
>          }
>  
>          if (encoding != null) {
> -            try {
> -                request.setCharacterEncoding(encoding);
> -            } catch (Exception e) {
> -                LOG.error("Error setting character encoding to '" + encoding + "' - ignoring.", e);
> +            String encoding2 = request.getCharacterEncoding();
> +            if (encoding2 == null) {
> +                try {
> +                    request.setCharacterEncoding(encoding);
> +                    LOG.info("Set Character Encoding to " + encoding + "!");
> +                } catch (Exception e) {
> +                    LOG.error("Error setting character encoding to '" + encoding + "' - ignoring.", e);
> +                }
> +            } else {
> +                LOG.info("Character Encoding is " + encoding2 + ".");
>              }
>          }
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.