You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2015/12/10 14:29:31 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1212
CLOUDSTACK-9136: remove ssh keypairs along with removing account
We also allow ROOT Admin to remove remained ssh keypairs of removed account
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack remove-ssh-keypairs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1212
----
commit 67e5e4719f7840753db6764f7e2205cbcdc8b7c2
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2015-12-10T13:25:22Z
CLOUDSTACK-9136: remove ssh keypairs along with removing account
We also allow ROOT Admin to remove remained ssh keypairs of removed account
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-219165095
@swill why not just test against 4.6 and then merge forward? if not, we need to rebase the branch. Pretty sure @ustcweizhou already did that in-house.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by agneya2001 <gi...@git.apache.org>.
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-163835153
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-219169003
That is fine, I don't mind doing that. Is that the process here? This is the first time I have handled a 4.6 PR. Will a 4.6 ever be released, or is that just not important and if someone wants one, they can grab master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1212
@karuturi this is ready for merge, using past review/test results. Though, I'll kick one more round of testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-219134524
@rhtyd I can run CI on this, but it is based against 4.6. I am not sure what to do about that. Should @ustcweizhou at least rebase against 4.7 so we can get it in and forward merge? I don't really want to be working against the 4.6 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164199618
@ustcweizhou Thanks! Will see them when they arrive!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by agneya2001 <gi...@git.apache.org>.
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-163939898
Sorry, I just started looking at PRs, next time I will elaborate on my LGTM.
For this particular one when a account is deleted it leaves the ssh key in the user table. Since, it is a few line fix I did a code review and it shows that the code will remove the ssh keys for all users under a removed account. Leaving ssh keys in db is not a good idea. This issue is there in 4.7 too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164191853
It is certainly not wanted but as it is in an otherwise working unit test it is allowed. It does not interfere with the correct working of the system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164178288
Until either a test is added, which is preferred! Or the dead code (see comment) is removed, :-1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1212
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1212
LGTM @karuturi this is ready for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1212
<b>Trillian test result (tid-884)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35787 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1212-t884-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 46 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 369.27 | test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | test_snapshots.py
test_01_vpc_site2site_vpn | Success | 164.37 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 65.86 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 260.56 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 276.46 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 536.00 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 509.24 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1411.07 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 552.30 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 748.25 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1298.60 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.24 | test_volumes.py
test_08_resize_volume | Success | 156.12 | test_volumes.py
test_07_resize_fail | Success | 156.26 | test_volumes.py
test_06_download_detached_volume | Success | 156.20 | test_volumes.py
test_05_detach_volume | Success | 155.79 | test_volumes.py
test_04_delete_attached_volume | Success | 151.51 | test_volumes.py
test_03_download_attached_volume | Success | 156.16 | test_volumes.py
test_02_attach_volume | Success | 95.35 | test_volumes.py
test_01_create_volume | Success | 716.02 | test_volumes.py
test_deploy_vm_multiple | Success | 267.03 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.53 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.13 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.66 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.65 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.66 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.13 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.27 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 61.10 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.33 | test_templates.py
test_03_delete_template | Success | 5.08 | test_templates.py
test_02_edit_template | Success | 90.11 | test_templates.py
test_01_create_template | Success | 30.33 | test_templates.py
test_10_destroy_cpvm | Success | 161.60 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.88 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.61 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.55 | test_ssvm.py
test_06_stop_cpvm | Success | 161.66 | test_ssvm.py
test_05_stop_ssvm | Success | 133.85 | test_ssvm.py
test_04_cpvm_internals | Success | 1.41 | test_ssvm.py
test_03_ssvm_internals | Success | 5.16 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
test_01_snapshot_root_disk | Success | 10.94 | test_snapshots.py
test_04_change_offering_small | Success | 239.57 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.08 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.14 | test_secondary_storage.py
test_09_reboot_router | Success | 40.29 | test_routers.py
test_08_start_router | Success | 30.23 | test_routers.py
test_07_stop_router | Success | 10.12 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.70 | test_routers.py
test_03_restart_network_cleanup | Success | 60.45 | test_routers.py
test_02_router_internal_adv | Success | 1.09 | test_routers.py
test_01_router_internal_basic | Success | 0.57 | test_routers.py
test_router_dns_guestipquery | Success | 76.71 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.06 | test_router_dns.py
test_router_dhcphosts | Success | 276.44 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.70 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.06 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 130.71 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.15 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.32 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 493.18 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 363.86 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 86.83 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.77 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.14 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.35 | test_portable_publicip.py
test_isolate_network_password_server | Success | 90.72 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.10 | test_over_provisioning.py
test_oobm_zchange_password | Success | 30.55 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.32 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.17 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.32 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.28 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.24 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.24 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 15.24 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 77.11 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.13 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.08 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 0.12 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.08 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.07 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 23.31 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.24 | test_non_contigiousvlan.py
test_01_nic | Success | 438.19 | test_nic.py
test_releaseIP | Success | 257.11 | test_network.py
test_reboot_router | Success | 402.69 | test_network.py
test_public_ip_user_account | Success | 10.19 | test_network.py
test_public_ip_admin_account | Success | 40.18 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.75 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.56 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.14 | test_network.py
test_delete_account | Success | 292.10 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.48 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.58 | test_network.py
test_nic_secondaryip_add_remove | Success | 226.99 | test_multipleips_per_nic.py
login_test_saml_user | Success | 17.79 | test_login.py
test_assign_and_removal_lb | Success | 134.03 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.34 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 230.34 | test_loadbalance.py
test_03_list_snapshots | Success | 0.05 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.04 | test_iso.py
test_05_iso_permissions | Success | 0.04 | test_iso.py
test_04_extract_Iso | Success | 5.35 | test_iso.py
test_03_delete_iso | Success | 95.16 | test_iso.py
test_02_edit_iso | Success | 0.04 | test_iso.py
test_01_create_iso | Success | 20.78 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 227.92 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 162.25 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 554.18 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 428.54 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.20 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.10 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 5.79 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 5.65 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.57 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.59 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 5.75 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 5.63 | test_dynamicroles.py
test_role_lifecycle_update | Success | 5.63 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.59 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 11.09 | test_dynamicroles.py
test_role_lifecycle_create | Success | 5.62 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.58 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 6.94 | test_dynamicroles.py
test_role_account_acls | Success | 7.13 | test_dynamicroles.py
test_default_role_deletion | Success | 5.65 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.06 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.05 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.08 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.59 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 40.50 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 55.50 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.27 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 55.54 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 5.67 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 5.79 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 233.25 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 206.74 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 166.16 | test_affinity_groups.py
test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: CLOUDSTACK-9136: remove ssh keypairs along with remo...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1212
rebased with apache/4.9, and added unit test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1212: CLOUDSTACK-9136: remove ssh keypairs along wi...
Posted by ustcweizhou <gi...@git.apache.org>.
GitHub user ustcweizhou reopened a pull request:
https://github.com/apache/cloudstack/pull/1212
CLOUDSTACK-9136: remove ssh keypairs along with removing account
We also allow ROOT Admin to remove remained ssh keypairs of removed account
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack remove-ssh-keypairs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1212
----
commit e57adc195cd12d9cffe1c55080e96bf07ef4473e
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2015-12-10T13:25:22Z
CLOUDSTACK-9136: remove ssh keypairs along with removing account
We also allow ROOT Admin to remove remained ssh keypairs of removed account
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1212: CLOUDSTACK-9136: remove ssh keypairs along wi...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou closed the pull request at:
https://github.com/apache/cloudstack/pull/1212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-163927873
@agneya2001 What made you LGTM this? the titel of the PR? The description of the feature in the ticket? code review? testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164174462
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
Result:
```
Check the password file in the Router VM ... === TestName: test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and check default routes ... === TestName: test_02_redundant_VPC_default_routes | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS ===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS ===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS ===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS ===
ok
test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_03_rvpc_privategw_static_routes | Status : SUCCESS ===
ok
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 38 tests in 22572.696s
OK
```
And:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_service_offerings.py \
smoke/test_network.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```
Result:
```
Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
ok
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok
Test to create service offering ... === TestName: test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: test_03_delete_service_offering | Status : SUCCESS ===
ok
Test for delete account ... === TestName: test_delete_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for admin account ... === TestName: test_public_ip_admin_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for user account ... === TestName: test_public_ip_user_account | Status : SUCCESS ===
ok
Test for release public IP address ... === TestName: test_releaseIP | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status : SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : SUCCESS ===
ok
test_09_create_redundant_vpc_offering (integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok
Test start/stop of router after addition of one guest network ... === TestName: test_01_start_stop_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest network ... === TestName: test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 41 tests in 10222.976s
OK
```
Didn't test the actual feature/fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1212
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164198697
@DaanHoogland I will add some tests in the file when I have time.
currently I have some other tasks to do (not porting).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by alexandrelimassantana <gi...@git.apache.org>.
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1212#discussion_r55956795
--- Diff: server/src/com/cloud/server/ManagementServerImpl.java ---
@@ -3567,7 +3567,17 @@ public boolean deleteSSHKeyPair(final DeleteSSHKeyPairCmd cmd) {
final Long domainId = cmd.getDomainId();
final Long projectId = cmd.getProjectId();
- final Account owner = _accountMgr.finalizeOwner(caller, accountName, domainId, projectId);
+ Account owner = null;
--- End diff --
Hello @ustcweizhou
I think this piece of code could be extracted from the deleteSSHKeyPair method. It has gotten a little big from it's past form and further improvements could be done outside of the main "deleteSSHKeyPair" flow if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164188525
@borisroman I don't agree with your :-1: The artifact from a port in a test class that otherwise compiles is worth a -1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164189121
Hi @DaanHoogland, well then that's your opinion. Mine is, as a developer I do not want dead code to be added to the project.
Therefore I stand by my :-1:
Could you please elaborate on why this in your opinion is wanted and/or allowed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1212
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1212#discussion_r47437500
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -185,6 +186,8 @@
@Mock
GlobalLoadBalancerRuleDao _gslbRuleDao;
@Mock
+ SSHKeyPairDao _sshKeyPairDao;
--- End diff --
@borisroman the unit tests will fail without this change.
anyway, I will add some codes in the test file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164201602
@ustcweizhou @borisroman we will release both 4.6.2 and 4.7.0 RDs tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-170342555
@ustcweizhou any update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1212#discussion_r47435698
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -185,6 +186,8 @@
@Mock
GlobalLoadBalancerRuleDao _gslbRuleDao;
@Mock
+ SSHKeyPairDao _sshKeyPairDao;
--- End diff --
You've added _sshKeyPairDao here. Without using it! Could you please write a test for the functionality you improved?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-216208175
@ustcweizhou can you rebase against latest master and share state of your PR, thanks
LGTM, though a marvin smoke test that can run with Travis would be great
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...
Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1212
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1212
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-219169448
Ok, what I will do is merge it into 4.6 and forward merge it to 4.7 and then run CI on it there. I also need to verify what is forward merged from 4.6 because I don't think I have done that yet...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-218959585
@swill this can be CI tested and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-175687426
LGTM, if we don't have any outstanding objections -- let's merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---