You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/07 19:24:55 UTC

[GitHub] [orc] belugabehr opened a new pull request #740: ORC-836: StringGroupFromDoubleTreeReader Use Long toString

belugabehr opened a new pull request #740:
URL: https://github.com/apache/orc/pull/740


   ### What changes were proposed in this pull request?
   When converting from Double to String, use the Double class methods directly. Lower overhead of encoding by using ASCII.
   
   
   ### Why are the changes needed?
   Performance.
   
   
   ### How was this patch tested?
   No change in functionality.  Use existing unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] belugabehr commented on pull request #740: ORC-836: StringGroupFromDoubleTreeReader Use Long toString

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #740:
URL: https://github.com/apache/orc/pull/740#issuecomment-879188017


   @dongjoon-hyun This is a trivial one.  Can you please take a look? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #740: ORC-836: StringGroupFromDoubleTreeReader Use Double toString

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #740:
URL: https://github.com/apache/orc/pull/740


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] belugabehr commented on pull request #740: ORC-836: StringGroupFromDoubleTreeReader Use Double toString

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #740:
URL: https://github.com/apache/orc/pull/740#issuecomment-879265008


   @dongjoon-hyun Thanks!!
   
   You are correct, I meant to say "Double" instead of ~Long~
   
   I changed the commit message.
   
   All other instances correctly use the `toString` instead of `valueOf`, this was the only one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org