You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/16 02:26:58 UTC

[GitHub] [flink] godfreyhe opened a new pull request #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig

godfreyhe opened a new pull request #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig
URL: https://github.com/apache/flink/pull/11763
 
 
   
   ## What is the purpose of the change
   
   *The config set by SET command does not work, the reason is table.xx property set from CLI does not be set into TableEnvironment's TableConfig.*
   
   
   ## Brief change log
   
     - *move TableConfig out side of SessionState, and create TableConfig when initializing TableEnvironment*
   
   
   ## Verifying this change
   
   
   
   This change added tests and can be verified as follows:
   
     - *Added testSetSessionProperties in LocalExecutorITCase to verify the bug*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig
URL: https://github.com/apache/flink/pull/11763#issuecomment-614382282
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3c97c5a1bc74f3abc643442fca2e46052fe91477",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160484046",
       "triggerID" : "3c97c5a1bc74f3abc643442fca2e46052fe91477",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3c97c5a1bc74f3abc643442fca2e46052fe91477 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160484046) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig
URL: https://github.com/apache/flink/pull/11763#issuecomment-614382282
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3c97c5a1bc74f3abc643442fca2e46052fe91477",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3c97c5a1bc74f3abc643442fca2e46052fe91477",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3c97c5a1bc74f3abc643442fca2e46052fe91477 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig
URL: https://github.com/apache/flink/pull/11763#issuecomment-614382282
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3c97c5a1bc74f3abc643442fca2e46052fe91477",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160484046",
       "triggerID" : "3c97c5a1bc74f3abc643442fca2e46052fe91477",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3c97c5a1bc74f3abc643442fca2e46052fe91477 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160484046) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig
URL: https://github.com/apache/flink/pull/11763
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11763: [FLINK-16822] [sql-client] `table.xx` property set from CLI should also be set into TableEnvironment's TableConfig
URL: https://github.com/apache/flink/pull/11763#issuecomment-614379894
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3c97c5a1bc74f3abc643442fca2e46052fe91477 (Thu Apr 16 02:35:06 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services