You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/26 18:28:16 UTC
[GitHub] [bookkeeper] dlg99 opened a new pull request #2551: Fixed failing tests for /stream.
dlg99 opened a new pull request #2551:
URL: https://github.com/apache/bookkeeper/pull/2551
Descriptions of the changes in this PR:
Fixed tests for /stream, RocksDB initialization.
### Motivation
Tests were failing with " “java.lang.UnsatisfiedLinkError: 'long org.rocksdb.LRUCache.newLRUCache(long, int, boolean, double)'”".
### Changes
Fixed following suggestion form https://github.com/facebook/rocksdb/issues/6789
Added
` static {
RocksDB.loadLibrary();
}`
to extract the native library from the jar file etc.
Master Issue: #2550
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks.
>
> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli closed pull request #2551: Fixed failing tests for /stream.
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #2551:
URL: https://github.com/apache/bookkeeper/pull/2551
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2551: Fixed failing tests for /stream.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2551:
URL: https://github.com/apache/bookkeeper/pull/2551#issuecomment-767842159
We should add a new CI workflow to run stream tests (as part of another PR).
I can do it tomorrow if you prefer. Thanks for the pointer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2551: Fixed failing tests for /stream.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2551:
URL: https://github.com/apache/bookkeeper/pull/2551#issuecomment-767812138
@lhotari we should also investigate why stream tests are not running on CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #2551: Fixed failing tests for /stream.
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2551:
URL: https://github.com/apache/bookkeeper/pull/2551#issuecomment-767836084
@eolivelli stream tests need "-DstreamTests" flag to run as defined in pom; while stream/statelib/ tests are fast, full stream/ test run (includes distributed logs) takes a lot of time, I guess they were disabled by default to speed the build up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org