[GitHub] vdiravka commented on a change in pull request #1566: DRILL-6887: Fix FunctionInitializerTest.init() failure

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #1566: DRILL-6887: Fix FunctionInitializerTest.init() failure
URL: https://github.com/apache/drill/pull/1566#discussion_r240012782
 
 

 ##########
 File path: exec/java-exec/src/test/resources/drill-udf/pom.xml
 ##########
 @@ -28,6 +28,8 @@
   <version>1.0</version>
 
   <properties>
+    <maven.compiler.source>1.8</maven.compiler.source>
+    <maven.compiler.target>1.8</maven.compiler.target>
 
 Review comment:
   After removing these properties the [default values](https://github.com/apache/maven-compiler-plugin/blob/875947802d28bcf8348eb634985c0512a790170a/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L169) for them will be 1.6:
   > Since `maven-compiler-plugin` 3.8.0 the default value has changed from 1.5 to 1.6 
   
   Even with explicit 1.6 values for `source` and `target` properties the tests pass, but these are not the right versions for current Drill version. 
   
   According to [Maven docs](https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html) we need to specify the properties for Java8.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services