[GitHub] spark pull request #15669: [SPARK-18160][CORE][YARN] spark.files should not ...

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15669#discussion_r85872343
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1716,29 +1716,12 @@ class SparkContext(config: SparkConf) extends Logging {
             key = uri.getScheme match {
               // A JAR file which exists only on the driver node
               case null | "file" =>
    -            if (master == "yarn" && deployMode == "cluster") {
    -              // In order for this to work in yarn cluster mode the user must specify the
    -              // --addJars option to the client to upload the file into the distributed cache
    -              // of the AM to make it show up in the current working directory.
    -              val fileName = new Path(uri.getPath).getName()
    -              try {
    -                env.rpcEnv.fileServer.addJar(new File(fileName))
    -              } catch {
    -                case e: Exception =>
    -                  // For now just log an error but allow to go through so spark examples work.
    -                  // The spark examples don't really need the jar distributed since its also
    -                  // the app jar.
    -                  logError("Error adding jar (" + e + "), was the --addJars option used?")
    -                  null
    -              }
    -            } else {
    -              try {
    -                env.rpcEnv.fileServer.addJar(new File(uri.getPath))
    -              } catch {
    -                case exc: FileNotFoundException =>
    -                  logError(s"Jar not found at $path")
    -                  null
    -              }
    --- End diff --
    
    These are obsoleted code IMO, so I remove them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org