[GitHub] [incubator-paimon] legendtkl commented on a diff in pull request #714: [WIP][core] support JDK 11

["legendtkl (via GitHub)" <gi...@apache.org>]

legendtkl commented on code in PR #714:
URL: https://github.com/apache/incubator-paimon/pull/714#discussion_r1148268278


##########
.github/workflows/e2e-tests-1.14.yml:
##########
@@ -32,10 +32,11 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v2
-      - name: Set up JDK 1.8
-        uses: actions/setup-java@v1
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
         with:
-          java-version: 1.8
+          java-version: '11'

Review Comment:
   @TyrantLucifer  OK, let's keep them both temporarily.
   
   But from a long-term view, supporting JDK11 without deprecating JDK8 is not a real upgrading. We have to do much meaningless work for the compatibility, and give up the JDK11 specified programing feature.
   
   I will open a new ISSUE to discuss the JDK8 Deprecation after this PR is merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org