You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/10 05:32:32 UTC
[GitHub] [pulsar] fantapsody opened a new pull request #10884: Remove the duplicated entry `advertisedAddress`
fantapsody opened a new pull request #10884:
URL: https://github.com/apache/pulsar/pull/10884
I noticed there're two entries with the name `advertisedAddress` in the table for the proxy, removed the old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #10884: Remove the duplicated entry `advertisedAddress`
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10884:
URL: https://github.com/apache/pulsar/pull/10884#issuecomment-859165537
@fantapsody thanks for your contribution.
Double-check:
The default value of is `N/A` rather than `InetAddress.getLocalHost().getHostname()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet edited a comment on pull request #10884: Remove the duplicated entry `advertisedAddress`
Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #10884:
URL: https://github.com/apache/pulsar/pull/10884#issuecomment-859165537
@fantapsody thanks for your contribution.
Double-check:
The default value of `advertisedAddress` is `N/A` rather than `InetAddress.getLocalHost().getHostname()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] fantapsody commented on pull request #10884: Remove the duplicated entry `advertisedAddress`
Posted by GitBox <gi...@apache.org>.
fantapsody commented on pull request #10884:
URL: https://github.com/apache/pulsar/pull/10884#issuecomment-859338810
> @fantapsody thanks for your contribution.
>
> Double-check:
>
> The default value of `advertisedAddress` is `N/A` rather than `InetAddress.getLocalHost().getHostname()`?
>
> 
@Anonymitaet I thought it was good to keep it consistent other configuration items that have the same name, as you can see in https://github.com/apache/pulsar/blob/c183296b9e1910bd6009821bd6150a214a926895/site2/docs/reference-configuration.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #10884: Remove the duplicated entry `advertisedAddress`
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #10884:
URL: https://github.com/apache/pulsar/pull/10884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org