You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/04/24 03:09:36 UTC
[GitHub] flink pull request #3758: [FLINK-5855][Streaming Connectors] Unprotected acc...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3758
[FLINK-5855][Streaming Connectors] Unprotected access to pendingFiles\u2026
\u2026PerCheckpoint in BucketingSink.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-5855
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3758
----
commit f99a1cfea95b4a7f1760d97526beac133a25d03b
Author: zhangminglei <zm...@163.com>
Date: 2017-04-24T03:08:17Z
[FLINK-5855][Streaming Connectors] Unprotected access to pendingFilesPerCheckpoint in BucketingSink.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3758
Yes. This sounds good, but you reopened this pull request right? Shouldn't this be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3758
@zhangminglei Perfect!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3758: [FLINK-5855][Streaming Connectors] Unprotected acc...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
@kl0u Yep. I reopened this PR again for waiting you message me. Haha ~ Okay, Now, I will close it and then create another jira and cc you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3758: [FLINK-5855][Streaming Connectors] Unprotected acc...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/3758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
@kl0u Thanks for review , very appreciate it. Yep, BTW, I would like to work on what you will thorough the code in the following days and keep watching this class ```synchronized()```. Hopes work on the new jira if you could assign to me. I will close this PR and JIRA as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3758
cc @tillrohrmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3758: [FLINK-5855][Streaming Connectors] Unprotected acc...
Posted by zhangminglei <gi...@git.apache.org>.
GitHub user zhangminglei reopened a pull request:
https://github.com/apache/flink/pull/3758
[FLINK-5855][Streaming Connectors] Unprotected access to pendingFiles\u2026
\u2026PerCheckpoint in BucketingSink.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-5855
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3758.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3758
----
commit f99a1cfea95b4a7f1760d97526beac133a25d03b
Author: zhangminglei <zm...@163.com>
Date: 2017-04-24T03:08:17Z
[FLINK-5855][Streaming Connectors] Unprotected access to pendingFilesPerCheckpoint in BucketingSink.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3758
Hi @zhangminglei, thanks for looking into this! I tend to agree with @tillrohrmann that there is not need for locking there, as there is no sharing of the data-structure between different threads. The same holds for the lock at line 726. So these 2 `synchronized()` clauses could go away.
I will have a more thorough look on the whole locking scheme in the class in the following days. But for now I think that this PR could be closed and the JIRA could be updated.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3758
Not sure why we're synchronizing on the `pendingFilesPerCheckpoint` field at all, because it is only the restored state object. Maybe @kl0u can shed some light on that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---