You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jojochuang (via GitHub)" <gi...@apache.org> on 2023/12/06 22:58:26 UTC
Re: [PR] HDDS-9750. [hsync] Make Putblock performance acceptable - Skeleton code [ozone]
jojochuang commented on code in PR #5661:
URL: https://github.com/apache/ozone/pull/5661#discussion_r1418074424
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java:
##########
@@ -89,18 +90,26 @@ public long putBlock(Container container, BlockData data) throws IOException {
return putBlock(container, data, true);
}
+ @Override
+ public long putBlock(Container container, BlockData data, boolean endOfBlock)
+ throws IOException {
+ return putBlock(container, data, endOfBlock, true);
Review Comment:
i'm going to refactor this one to make it clear, but basically the client side will have a flag in PutBlock request to hint it carries incremental chunk list. If the flag is false it falls back to the original behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org