[jira] [Comment Edited] (IGNITE-4530) Passing AWSCredentialsProvider to TcpDiscoveryS3IpFinder

["Denis Magda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813333#comment-15813333 ] 

Denis Magda edited comment on IGNITE-4530 at 1/10/17 12:21 AM:
---------------------------------------------------------------

[~akazlou], thanks a lot. In general, everything looks good so far. I left a minor note in the pull request on GitHub. Please address it.

BTW, did you use your personal AWS account for the updated API testing?

Finally, please move the ticket into "patch available" state if it's truly ready for a review.



was (Author: dmagda):
[~akazlou], thanks a lot. In general, everything looks good so far. I left a minor note in the pull request on GitHub. Please address it.

BTW, did you use your personal AWS account for the updated API testing?



> Passing AWSCredentialsProvider to TcpDiscoveryS3IpFinder
> --------------------------------------------------------
>
>                 Key: IGNITE-4530
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4530
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Denis Magda
>            Assignee: Aliaksandr Kazlou
>
> {{TcpDiscoveryS3IpFinder}} accepts credentials in a form of {{AWSCredentials}} only. This might not be enough for all the cases. In a situation when the credentials get expired a special instance of {{AWSCredentialsProvider}} can renew them automatically.
> However, the credentials will not be updated if {{StaticCredentialsProvider}} is used. This provider is created automatically if user provides raw {{AWSCredentials}}.
> We need to add new method to {{TcpDiscoveryS3IpFinder}} that will accept {{AWSCredentialsProvider}}:
> {code}
>     public void setAwsCredentialsProvider(AWSCredentialsProvider provider) {
> {code}
> A new test has to be added to {{TcpDiscoveryS3IpFinderSelfTest}} as well.
> For more details refer to a discussion on the user list:
> http://apache-ignite-users.70518.x6.nabble.com/Old-AWS-SDK-version-why-td9824.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)