You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vishal Ghugare <gh...@us.ibm.com> on 2015/12/16 23:20:20 UTC
Review Request 41469: AMBARI-12686 : [RM HA] YARN service shows RED
when one of RM goes down but the active RM works fine
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41469/
-----------------------------------------------------------
Review request for Ambari and Robert Levas.
Bugs: AMBARI-12686
https://issues.apache.org/jira/browse/AMBARI-12686
Repository: ambari
Description
-------
In a RM HA setup, YARN could work ever there is only 1 RM available, I would expect the service status for YARN is yellow or green(with alerts) from UI instead of red.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 7a3d330
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java f067f49
Diff: https://reviews.apache.org/r/41469/diff/
Testing
-------
6 unit tests have been added to test YARN service status. These tests basically cover the service status when:
-all yarn services Installed (HA)
-all yarn services Started (HA)
-one RM Started and the other one Installed (HA)
-both RMs are Installed (HA)
-Has only one RM and it is Started (Non-HA)
-Has only one RM and it is Installed (Non-HA)
Thanks,
Vishal Ghugare
Re: Review Request 41469: AMBARI-12686 : [RM HA] YARN service shows
RED when one of RM goes down but the active RM works fine
Posted by Vishal Ghugare <gh...@us.ibm.com>.
> On Dec. 16, 2015, 2:35 p.m., Robert Levas wrote:
> > Ship It!
>
> Vishal Ghugare wrote:
> Thanks Robert for the review. I would appreciate if you can help me commit the code (I am not a commiter).
>
> Robert Levas wrote:
> Sure... I am running unit tests now.
>
> Robert Levas wrote:
> Committed to trunk.... you can close this review
> ```
> commit a93c5d2892b92ae22b3d1b7f7967dc43d45f6740
> Author: Vishal Ghugare <gh...@us.ibm.com>
> Date: Thu Dec 17 09:43:33 2015 -0500
> ```
Thanks Robert!
- Vishal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41469/#review110774
-----------------------------------------------------------
On Dec. 16, 2015, 2:20 p.m., Vishal Ghugare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41469/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 2:20 p.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Bugs: AMBARI-12686
> https://issues.apache.org/jira/browse/AMBARI-12686
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In a RM HA setup, YARN could work ever there is only 1 RM available, I would expect the service status for YARN is yellow or green(with alerts) from UI instead of red.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 7a3d330
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java f067f49
>
> Diff: https://reviews.apache.org/r/41469/diff/
>
>
> Testing
> -------
>
> 6 unit tests have been added to test YARN service status. These tests basically cover the service status when:
> -all yarn services Installed (HA)
> -all yarn services Started (HA)
> -one RM Started and the other one Installed (HA)
> -both RMs are Installed (HA)
> -Has only one RM and it is Started (Non-HA)
> -Has only one RM and it is Installed (Non-HA)
>
>
> Thanks,
>
> Vishal Ghugare
>
>
Re: Review Request 41469: AMBARI-12686 : [RM HA] YARN service shows
RED when one of RM goes down but the active RM works fine
Posted by Vishal Ghugare <gh...@us.ibm.com>.
> On Dec. 16, 2015, 2:35 p.m., Robert Levas wrote:
> > Ship It!
Thanks Robert for the review. I would appreciate if you can help me commit the code (I am not a commiter).
- Vishal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41469/#review110774
-----------------------------------------------------------
On Dec. 16, 2015, 2:20 p.m., Vishal Ghugare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41469/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 2:20 p.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Bugs: AMBARI-12686
> https://issues.apache.org/jira/browse/AMBARI-12686
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In a RM HA setup, YARN could work ever there is only 1 RM available, I would expect the service status for YARN is yellow or green(with alerts) from UI instead of red.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 7a3d330
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java f067f49
>
> Diff: https://reviews.apache.org/r/41469/diff/
>
>
> Testing
> -------
>
> 6 unit tests have been added to test YARN service status. These tests basically cover the service status when:
> -all yarn services Installed (HA)
> -all yarn services Started (HA)
> -one RM Started and the other one Installed (HA)
> -both RMs are Installed (HA)
> -Has only one RM and it is Started (Non-HA)
> -Has only one RM and it is Installed (Non-HA)
>
>
> Thanks,
>
> Vishal Ghugare
>
>
Re: Review Request 41469: AMBARI-12686 : [RM HA] YARN service shows
RED when one of RM goes down but the active RM works fine
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 16, 2015, 5:35 p.m., Robert Levas wrote:
> > Ship It!
>
> Vishal Ghugare wrote:
> Thanks Robert for the review. I would appreciate if you can help me commit the code (I am not a commiter).
Sure... I am running unit tests now.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41469/#review110774
-----------------------------------------------------------
On Dec. 16, 2015, 5:20 p.m., Vishal Ghugare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41469/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 5:20 p.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Bugs: AMBARI-12686
> https://issues.apache.org/jira/browse/AMBARI-12686
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In a RM HA setup, YARN could work ever there is only 1 RM available, I would expect the service status for YARN is yellow or green(with alerts) from UI instead of red.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 7a3d330
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java f067f49
>
> Diff: https://reviews.apache.org/r/41469/diff/
>
>
> Testing
> -------
>
> 6 unit tests have been added to test YARN service status. These tests basically cover the service status when:
> -all yarn services Installed (HA)
> -all yarn services Started (HA)
> -one RM Started and the other one Installed (HA)
> -both RMs are Installed (HA)
> -Has only one RM and it is Started (Non-HA)
> -Has only one RM and it is Installed (Non-HA)
>
>
> Thanks,
>
> Vishal Ghugare
>
>
Re: Review Request 41469: AMBARI-12686 : [RM HA] YARN service shows
RED when one of RM goes down but the active RM works fine
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 16, 2015, 5:35 p.m., Robert Levas wrote:
> > Ship It!
>
> Vishal Ghugare wrote:
> Thanks Robert for the review. I would appreciate if you can help me commit the code (I am not a commiter).
>
> Robert Levas wrote:
> Sure... I am running unit tests now.
Committed to trunk.... you can close this review
```
commit a93c5d2892b92ae22b3d1b7f7967dc43d45f6740
Author: Vishal Ghugare <gh...@us.ibm.com>
Date: Thu Dec 17 09:43:33 2015 -0500
```
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41469/#review110774
-----------------------------------------------------------
On Dec. 16, 2015, 5:20 p.m., Vishal Ghugare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41469/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 5:20 p.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Bugs: AMBARI-12686
> https://issues.apache.org/jira/browse/AMBARI-12686
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In a RM HA setup, YARN could work ever there is only 1 RM available, I would expect the service status for YARN is yellow or green(with alerts) from UI instead of red.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 7a3d330
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java f067f49
>
> Diff: https://reviews.apache.org/r/41469/diff/
>
>
> Testing
> -------
>
> 6 unit tests have been added to test YARN service status. These tests basically cover the service status when:
> -all yarn services Installed (HA)
> -all yarn services Started (HA)
> -one RM Started and the other one Installed (HA)
> -both RMs are Installed (HA)
> -Has only one RM and it is Started (Non-HA)
> -Has only one RM and it is Installed (Non-HA)
>
>
> Thanks,
>
> Vishal Ghugare
>
>
Re: Review Request 41469: AMBARI-12686 : [RM HA] YARN service shows
RED when one of RM goes down but the active RM works fine
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41469/#review110774
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Dec. 16, 2015, 5:20 p.m., Vishal Ghugare wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41469/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 5:20 p.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Bugs: AMBARI-12686
> https://issues.apache.org/jira/browse/AMBARI-12686
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In a RM HA setup, YARN could work ever there is only 1 RM available, I would expect the service status for YARN is yellow or green(with alerts) from UI instead of red.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 7a3d330
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java f067f49
>
> Diff: https://reviews.apache.org/r/41469/diff/
>
>
> Testing
> -------
>
> 6 unit tests have been added to test YARN service status. These tests basically cover the service status when:
> -all yarn services Installed (HA)
> -all yarn services Started (HA)
> -one RM Started and the other one Installed (HA)
> -both RMs are Installed (HA)
> -Has only one RM and it is Started (Non-HA)
> -Has only one RM and it is Installed (Non-HA)
>
>
> Thanks,
>
> Vishal Ghugare
>
>