You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by Janardhan <ja...@apache.org> on 2021/12/01 18:41:39 UTC
[DISCUSS] Consistent version change during git tag creation
Hi all,
During the release tag creation[1], only the version in the pom.xml[2]
gets updated.
mvn -Dtag=$RELEASE_TAG release:prepare
We got to change the version in the following places, at the tag creation time
In the src/main/python/systemds/project_info.py
and docs/_config.yml#L42
A workaround for this would be to execute bash (sed -i ..) from pom.xml
with <execution> tag.
Any ideas?
--
[1] https://github.com/apache/systemds/blob/main/dev/release/create-tag.sh#L120
[2] https://github.com/apache/systemds/commit/6e938bdbc6071bf6919640356428f6c05fd25033
Best Regards,
Janardhan
Re: [DISCUSS] Consistent version change during git tag creation
Posted by Mark Dokter <md...@know-center.at>.
Hi!
The release plugin is restrictive and over-complicates things. I don't
like it and all the steps it does can be done in separate steps too.
Anyway. Why not change our process a little bit that after successful
voting one more change that only touches the version information is
allowed? Then you can release the correct version via script right away
and don't need to fiddle with versions manually.
Regards, Mark
On 01.12.21 20:12, arnab phani wrote:
> That is true.
> For now, we have to live with the manual commits post RC generation.
> I will think about a way to bring it into the automation process.
>
> Regards,
> Arnab..
>
> On Wed, Dec 1, 2021 at 8:03 PM Janardhan <ja...@apache.org> wrote:
>
>> sed inplace in the release scripts is not possible because,
>> mvn release:prepare expects no changes in the
>> working directory. :(
>>
>>
>>
>> On Thu, Dec 2, 2021 at 12:18 AM arnab phani <ph...@gmail.com> wrote:
>>>
>>> Sed inplace is fine for these. You can add that in the same script where
>>> you call mvn -Dtag.
>>>
>>> Regards,
>>> Arnab..
>>>
>>> On Wed, Dec 1, 2021, 19:42 Janardhan <ja...@apache.org> wrote:
>>>
>>>> Hi all,
>>>>
>>>> During the release tag creation[1], only the version in the pom.xml[2]
>>>> gets updated.
>>>>
>>>> mvn -Dtag=$RELEASE_TAG release:prepare
>>>>
>>>> We got to change the version in the following places, at the tag
>> creation
>>>> time
>>>>
>>>> In the src/main/python/systemds/project_info.py
>>>> and docs/_config.yml#L42
>>>>
>>>> A workaround for this would be to execute bash (sed -i ..) from pom.xml
>>>> with <execution> tag.
>>>>
>>>> Any ideas?
>>>>
>>>> --
>>>> [1]
>>>>
>> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsystemds%2Fblob%2Fmain%2Fdev%2Frelease%2Fcreate-tag.sh%23L120&data=04%7C01%7Cmdokter%40know-center.at%7C1ce3eea81ebe418e632108d9b4fe8c8f%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637739828204761927%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=9qty2jBY%2FiqQICMogbU77MAESP6sF6c18AnbOGnZs8k%3D&reserved=0
>>>> [2]
>>>>
>> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsystemds%2Fcommit%2F6e938bdbc6071bf6919640356428f6c05fd25033&data=04%7C01%7Cmdokter%40know-center.at%7C1ce3eea81ebe418e632108d9b4fe8c8f%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637739828204761927%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=rN9T1Dxg6Zuz54JgtCa1GJYREYJSapJaS3klcgFAA0w%3D&reserved=0
>>>>
>>>> Best Regards,
>>>> Janardhan
>>>>
>>
>
Re: [DISCUSS] Consistent version change during git tag creation
Posted by arnab phani <ph...@gmail.com>.
That is true.
For now, we have to live with the manual commits post RC generation.
I will think about a way to bring it into the automation process.
Regards,
Arnab..
On Wed, Dec 1, 2021 at 8:03 PM Janardhan <ja...@apache.org> wrote:
> sed inplace in the release scripts is not possible because,
> mvn release:prepare expects no changes in the
> working directory. :(
>
>
>
> On Thu, Dec 2, 2021 at 12:18 AM arnab phani <ph...@gmail.com> wrote:
> >
> > Sed inplace is fine for these. You can add that in the same script where
> > you call mvn -Dtag.
> >
> > Regards,
> > Arnab..
> >
> > On Wed, Dec 1, 2021, 19:42 Janardhan <ja...@apache.org> wrote:
> >
> > > Hi all,
> > >
> > > During the release tag creation[1], only the version in the pom.xml[2]
> > > gets updated.
> > >
> > > mvn -Dtag=$RELEASE_TAG release:prepare
> > >
> > > We got to change the version in the following places, at the tag
> creation
> > > time
> > >
> > > In the src/main/python/systemds/project_info.py
> > > and docs/_config.yml#L42
> > >
> > > A workaround for this would be to execute bash (sed -i ..) from pom.xml
> > > with <execution> tag.
> > >
> > > Any ideas?
> > >
> > > --
> > > [1]
> > >
> https://github.com/apache/systemds/blob/main/dev/release/create-tag.sh#L120
> > > [2]
> > >
> https://github.com/apache/systemds/commit/6e938bdbc6071bf6919640356428f6c05fd25033
> > >
> > > Best Regards,
> > > Janardhan
> > >
>
Re: [DISCUSS] Consistent version change during git tag creation
Posted by Janardhan <ja...@apache.org>.
sed inplace in the release scripts is not possible because,
mvn release:prepare expects no changes in the
working directory. :(
On Thu, Dec 2, 2021 at 12:18 AM arnab phani <ph...@gmail.com> wrote:
>
> Sed inplace is fine for these. You can add that in the same script where
> you call mvn -Dtag.
>
> Regards,
> Arnab..
>
> On Wed, Dec 1, 2021, 19:42 Janardhan <ja...@apache.org> wrote:
>
> > Hi all,
> >
> > During the release tag creation[1], only the version in the pom.xml[2]
> > gets updated.
> >
> > mvn -Dtag=$RELEASE_TAG release:prepare
> >
> > We got to change the version in the following places, at the tag creation
> > time
> >
> > In the src/main/python/systemds/project_info.py
> > and docs/_config.yml#L42
> >
> > A workaround for this would be to execute bash (sed -i ..) from pom.xml
> > with <execution> tag.
> >
> > Any ideas?
> >
> > --
> > [1]
> > https://github.com/apache/systemds/blob/main/dev/release/create-tag.sh#L120
> > [2]
> > https://github.com/apache/systemds/commit/6e938bdbc6071bf6919640356428f6c05fd25033
> >
> > Best Regards,
> > Janardhan
> >
Re: [DISCUSS] Consistent version change during git tag creation
Posted by arnab phani <ph...@gmail.com>.
Sed inplace is fine for these. You can add that in the same script where
you call mvn -Dtag.
Regards,
Arnab..
On Wed, Dec 1, 2021, 19:42 Janardhan <ja...@apache.org> wrote:
> Hi all,
>
> During the release tag creation[1], only the version in the pom.xml[2]
> gets updated.
>
> mvn -Dtag=$RELEASE_TAG release:prepare
>
> We got to change the version in the following places, at the tag creation
> time
>
> In the src/main/python/systemds/project_info.py
> and docs/_config.yml#L42
>
> A workaround for this would be to execute bash (sed -i ..) from pom.xml
> with <execution> tag.
>
> Any ideas?
>
> --
> [1]
> https://github.com/apache/systemds/blob/main/dev/release/create-tag.sh#L120
> [2]
> https://github.com/apache/systemds/commit/6e938bdbc6071bf6919640356428f6c05fd25033
>
> Best Regards,
> Janardhan
>