You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/12 04:41:47 UTC

[GitHub] [geode-native] moleske commented on a change in pull request #661: GEODE-8512: Add expectDomainClass for PdxInstance

moleske commented on a change in pull request #661:
URL: https://github.com/apache/geode-native/pull/661#discussion_r503035325



##########
File path: CMakeLists.txt
##########
@@ -254,6 +254,7 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     -Wno-undefined-func-template #TODO fix
     -Wno-float-equal #TODO fix
     -Wno-conversion #TODO fix
+    -Wno-missing-variable-declarations #TODO fix

Review comment:
       Is there a reason this was added back in?  It was recently fixed in https://github.com/apache/geode-native/pull/645 with it only being applied to the [old integration tests](https://github.com/apache/geode-native/blob/develop/cppcache/integration-test/CMakeLists.txt#L110) to save hassle on the old stuff




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org