[GitHub] [druid] georgew5656 commented on a diff in pull request #13796: helm: Add customizable global and per-container env vars to helm chart

["georgew5656 (via GitHub)" <gi...@apache.org>]

georgew5656 commented on code in PR #13796:
URL: https://github.com/apache/druid/pull/13796#discussion_r1137160686


##########
helm/druid/templates/middleManager/statefulset.yaml:
##########
@@ -73,7 +73,7 @@ spec:
               topologyKey: kubernetes.io/hostname
               labelSelector:
                 matchLabels:
-                  app: "{{ template "druid.name" . }}"
+                  app: {{ template "druid.name" . | quote }}

Review Comment:
   is there a reason this field has to use the quote function instead of just quoting the value? it seems like most of the other fields in this chart use quotes, e.g.
   "{{ .Release.Name }}" instead of {{ .Release.Name | quote }}



##########
helm/druid/templates/broker/deployment.yaml:
##########
@@ -65,10 +65,16 @@ spec:
             valueFrom:  {fieldRef: {fieldPath: metadata.name}}
           - name: POD_NAMESPACE
             valueFrom: {fieldRef: {fieldPath: metadata.namespace}}
+          {{- with .Values.env }}
+            {{- toYaml . | nindent 10 }}
+          {{- end }}
           {{- range $key, $val := .Values.broker.config }}
           - name: {{ $key }}
             value: {{ $val | quote }}
-          {{- end}}
+          {{- end }}
+          {{- with .Values.broker.env }}

Review Comment:
   can we call these values extraEnv or extraEnvVars? for additional env variables this seems to be more the format
   https://github.com/codecentric/helm-charts/tree/master/charts/keycloak
   https://artifacthub.io/packages/helm/bitnami/nginx
   https://artifacthub.io/packages/helm/bitnami/mysql



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org