You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Ted Dunning (JIRA)" <ji...@apache.org> on 2011/04/13 19:32:06 UTC
[jira] [Created] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Scripts should specify bash instead of /bin/sh
----------------------------------------------
Key: MAHOUT-669
URL: https://issues.apache.org/jira/browse/MAHOUT-669
Project: Mahout
Issue Type: Bug
Reporter: Ted Dunning
Ken Williams said:
{quote}
Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
script should be a bash script (#!/bin/bash) rather than a standard
shell (#!/bin/sh) script.
$ trunk/examples/bin/build-cluster-syntheticcontrol.sh
trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
unexpected (expecting "fi")
$
{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Ken Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019739#comment-13019739 ]
Ken Williams commented on MAHOUT-669:
-------------------------------------
I have a patch file - how do I actually commit it ?
Ken
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Ted Dunning
> Fix For: 0.5
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019745#comment-13019745 ]
Sebastian Schelter commented on MAHOUT-669:
-------------------------------------------
just attach the patch file here (best to name it MAHOUT-669.patch), someone with commit access will review it and commit it afterwards
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Ted Dunning
> Fix For: 0.5
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen updated MAHOUT-669:
-----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Ted Dunning
> Fix For: 0.5
>
> Attachments: mahuot-669.patch
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Ken Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ken Williams updated MAHOUT-669:
--------------------------------
Attachment: mahuot-669.patch
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Ted Dunning
> Fix For: 0.5
>
> Attachments: mahuot-669.patch
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Ken Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019750#comment-13019750 ]
Ken Williams commented on MAHOUT-669:
-------------------------------------
I see, I click 'More Actions', etc.
Thanks lots,
Ken
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Ted Dunning
> Fix For: 0.5
>
> Attachments: mahuot-669.patch
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019831#comment-13019831 ]
Hudson commented on MAHOUT-669:
-------------------------------
Integrated in Mahout-Quality #747 (See [https://hudson.apache.org/hudson/job/Mahout-Quality/747/])
MAHOUT-669 script must have a bash shebang
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Ted Dunning
> Fix For: 0.5
>
> Attachments: mahuot-669.patch
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Lance Norskog (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020151#comment-13020151 ]
Lance Norskog commented on MAHOUT-669:
--------------------------------------
One "standard" is
#!/usr/bin/env bash
This walks through the incoming path and finds the first 'bash' program.
[http://en.wikipedia.org/wiki/Shebang_(Unix)#Portability]
But, Amazon Map/Reduce does not support it, even though it's Posix:
[https://forums.aws.amazon.com/thread.jspa?threadID=60007]
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Ted Dunning
> Fix For: 0.5
>
> Attachments: mahuot-669.patch
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Ken Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ken Williams updated MAHOUT-669:
--------------------------------
Affects Version/s: 0.5
Status: Patch Available (was: Open)
Patch changes 'examples/bin/build-cluster-syntheticcontrol.sh' from being a standard shell script to a bash shell script.
I've not converted any of the other shell scripts at the moment because I've not had a chance to check them.
Ken
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Ted Dunning
> Fix For: 0.5
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAHOUT-669) Scripts should specify bash instead
of /bin/sh
Posted by "Ted Dunning (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Dunning updated MAHOUT-669:
-------------------------------
Fix Version/s: 0.5
> Scripts should specify bash instead of /bin/sh
> ----------------------------------------------
>
> Key: MAHOUT-669
> URL: https://issues.apache.org/jira/browse/MAHOUT-669
> Project: Mahout
> Issue Type: Bug
> Reporter: Ted Dunning
> Fix For: 0.5
>
>
> Ken Williams said:
> {quote}
> Just out of interest, I also reckon your 'build-cluster-syntheticcontrol.sh'
> script should be a bash script (#!/bin/bash) rather than a standard
> shell (#!/bin/sh) script.
> $ trunk/examples/bin/build-cluster-syntheticcontrol.sh
> trunk/examples/bin/build-cluster-syntheticcontrol.sh: 28: Syntax error: "("
> unexpected (expecting "fi")
> $
> {quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira