[GitHub] [arrow] sunchao commented on a change in pull request #8528: ARROW-10390: [Rust][Parquet] Ensure it is possible to create custom parquet writers

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #8528:
URL: https://github.com/apache/arrow/pull/8528#discussion_r512158360



##########
File path: rust/parquet/tests/custom_writer.rs
##########
@@ -0,0 +1,83 @@
+use std::fs::File;

Review comment:
       nit: license header

##########
File path: rust/parquet/src/file/writer.rs
##########
@@ -38,7 +38,10 @@ use crate::file::{
     statistics::to_thrift as statistics_to_thrift, FOOTER_SIZE, PARQUET_MAGIC,
 };
 use crate::schema::types::{self, SchemaDescPtr, SchemaDescriptor, TypePtr};
-use crate::util::io::{FileSink, Position, TryClone};
+use crate::util::io::{FileSink, Position};
+
+// Exposed publically so client code can implement ParquetWriter

Review comment:
       nit: perhaps make ParquetWriter a linked text.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org