[GitHub] [hudi] nsivabalan commented on a change in pull request #4113: [HUDI-2735] Fix clean rollback archiving logic

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #4113:
URL: https://github.com/apache/hudi/pull/4113#discussion_r756527084



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTimelineArchiveLog.java
##########
@@ -140,20 +140,6 @@ public boolean archiveIfRequired(HoodieEngineContext context) throws IOException
     }
   }
 
-  private Stream<HoodieInstant> getCleanInstantsToArchive() {
-    HoodieTimeline cleanAndRollbackTimeline = table.getActiveTimeline()
-        .getTimelineOfActions(CollectionUtils.createSet(HoodieTimeline.CLEAN_ACTION, HoodieTimeline.ROLLBACK_ACTION)).filterCompletedInstants();
-    return cleanAndRollbackTimeline.getInstants()
-        .collect(Collectors.groupingBy(HoodieInstant::getAction)).values().stream()
-        .map(hoodieInstants -> {
-          if (hoodieInstants.size() > this.maxInstantsToKeep) {
-            return hoodieInstants.subList(0, hoodieInstants.size() - this.minInstantsToKeep);
-          } else {
-            return new ArrayList<HoodieInstant>();
-          }
-        }).flatMap(Collection::stream);

Review comment:
       if existing logic checks total rollback instants > config value, then wondering why @yihua was facing the issue w/ kafka connect? Do we know if the rollback was completed or was inflight ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org