[GitHub] [flink] WeiZhong94 opened a new pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API

[GitBox <gi...@apache.org>]

WeiZhong94 opened a new pull request #8488: [FLINK-12308][python] Add FileSystem Connector with CSV format support in Python Table API
URL: https://github.com/apache/flink/pull/8488
 
 
   ## What is the purpose of the change
   
   This pull request adds all descriptor interfaces, FileSystem connector and OldCSV format in Python Table API. 
   
   The implementation of them in Python Table API is just Py4J wrappers of their java classes. The reason of adding OldCsv format instead of Csv format is that the new Csv format only works on Kafka connector. Although OldCsv is deprecated, it is the only choice currently.
   
   I think there are at least 2 questions that need to be talked in this PR:
   1. In the Rowtime class, there are two APIs that define the watermark strategy. Do we need to keep both of them?
   2. Is an end-to-end test of descriptors necessary? e.g. the test case in `test_descriptor_end_to_end.py`.
   
   
   ## Brief change log
   
     - *Add all of the existing descriptor interfaces align Java Table API.*
     - *Add FileSystem connector and OldCsv format support.*
     - *Add test cases of above code.*
     - *Adjust travis script and pyflink gateway server script to include necessary jars.*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   Added integration tests: `test_descriptor_end_to_end.py`, `test_file_system_descriptor.py`, `test_old_csv_descriptor.py`, `test_rowtime_descriptor.py`, `test_schema_descriptor.py`, `test_table_descriptor.py`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (Python doc)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services