You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Blake Bender <bb...@vmware.com> on 2021/03/29 18:24:07 UTC
Very old geode-native PRs
Good morning!
We are attempting to push through all of the most longstanding geode-native PRs, so if you're involved in one as an author or a reviewer your prompt attention would be much appreciated. There are 4 outstanding that I consider "very old," all initially submitted prior to the first of the year. Here they are, with the latest statuses as I understand them.
1. PR 678, for GEODE-8601: https://github.com/apache/geode-native/pull/678. This one had an outstanding "change requested" review, which has kindly been removed this morning to unblock progress. All CI checks are passing, so I will request a review internally today to see if there's anything that really must be done prior to merging.
2. PR 699 for GEODE-8698: https://github.com/apache/geode-native/pull/699. This has an outstanding "change requested" review, so I will contact the author of that today to follow up. CI tasks are in a strange "pending" state, so it looks like this one was originally submitted prior to our making the CI public, and the new CI hasn't been run. If the author would be kind enough to push an empty commit, that should probably force a run and we can see what state the code is in. A rebase onto the latest develop branch is in order here, as well.
3. PR 705, for GEODE-8543: https://github.com/apache/geode-native/pull/705. Again the "change requested" review has been removed, and I will follow up with the team to get a new review ASAP. This one is also in a stuck state with respect to CI, so again a rebase and push to clear things up would be appreciated.
4. PR 713, for GEODE-8442: https://github.com/apache/geode-native/pull/713. This one has had quite a bit of attention recently, and was rebased 10 days ago. Review has been approved, and one integration test is failing in CI on all platforms. Author has been notified.
Thanks,
Blake
Re: Very old geode-native PRs
Posted by Mario Salazar de Torres <ma...@est.tech>.
Hi @Blake Bender<ma...@vmware.com>,
Thanks for taking some time on clearing out old PRs. I'll progress #699, so it can be closed ASAP.
BR,
Mario.
________________________________
From: Blake Bender <bb...@vmware.com>
Sent: Monday, March 29, 2021 8:24 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Very old geode-native PRs
Good morning!
We are attempting to push through all of the most longstanding geode-native PRs, so if you're involved in one as an author or a reviewer your prompt attention would be much appreciated. There are 4 outstanding that I consider "very old," all initially submitted prior to the first of the year. Here they are, with the latest statuses as I understand them.
1. PR 678, for GEODE-8601: https://github.com/apache/geode-native/pull/678. This one had an outstanding "change requested" review, which has kindly been removed this morning to unblock progress. All CI checks are passing, so I will request a review internally today to see if there's anything that really must be done prior to merging.
2. PR 699 for GEODE-8698: https://github.com/apache/geode-native/pull/699. This has an outstanding "change requested" review, so I will contact the author of that today to follow up. CI tasks are in a strange "pending" state, so it looks like this one was originally submitted prior to our making the CI public, and the new CI hasn't been run. If the author would be kind enough to push an empty commit, that should probably force a run and we can see what state the code is in. A rebase onto the latest develop branch is in order here, as well.
3. PR 705, for GEODE-8543: https://github.com/apache/geode-native/pull/705. Again the "change requested" review has been removed, and I will follow up with the team to get a new review ASAP. This one is also in a stuck state with respect to CI, so again a rebase and push to clear things up would be appreciated.
4. PR 713, for GEODE-8442: https://github.com/apache/geode-native/pull/713. This one has had quite a bit of attention recently, and was rebased 10 days ago. Review has been approved, and one integration test is failing in CI on all platforms. Author has been notified.
Thanks,
Blake