svn commit: r755970 - /tuscany/branches/sca-java-1.x/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingProcessor.java

[ra...@apache.org]

Author: ramkumar
Date: Thu Mar 19 12:23:15 2009
New Revision: 755970

URL: http://svn.apache.org/viewvc?rev=755970&view=rev
Log:
Fixes for TUSCANY-2922

Modified:
    tuscany/branches/sca-java-1.x/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingProcessor.java

Modified: tuscany/branches/sca-java-1.x/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingProcessor.java
URL: http://svn.apache.org/viewvc/tuscany/branches/sca-java-1.x/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingProcessor.java?rev=755970&r1=755969&r2=755970&view=diff
==============================================================================
--- tuscany/branches/sca-java-1.x/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingProcessor.java (original)
+++ tuscany/branches/sca-java-1.x/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingProcessor.java Thu Mar 19 12:23:15 2009
@@ -138,7 +138,6 @@
     private ConfiguredOperationProcessor configuredOperationProcessor;
     protected StAXArtifactProcessor<Object> extensionProcessor;
     private Monitor monitor;
-    protected String validationMessage;
 
     private ModelFactoryExtensionPoint modelFactories; // DOB
     public JMSBindingProcessor(ModelFactoryExtensionPoint modelFactories, StAXArtifactProcessor<Object> extensionProcessor, Monitor monitor) {
@@ -148,7 +147,6 @@
             new ConfiguredOperationProcessor(modelFactories, this.monitor);
         this.extensionProcessor = extensionProcessor;
         this.monitor = monitor;
-        this.validationMessage = null;
         this.modelFactories = modelFactories;
     }
     
@@ -177,7 +175,6 @@
     private void error(String message, Object model, Object... messageParameters) {
         if (monitor != null) {
             Problem problem = new ProblemImpl(this.getClass().getName(), "binding-jms-validation-messages", Severity.ERROR, model, message, (Object[])messageParameters);
-            validationMessage = problem.toString(); // Record error message for use in validation.
      	    monitor.problem(problem);
         }        
     }
@@ -193,7 +190,6 @@
     public JMSBinding read(XMLStreamReader reader) throws ContributionReadException, XMLStreamException {
         JMSBinding jmsBinding = new JMSBinding();
         // Reset validation message to keep track of validation issues.
-        this.validationMessage = null;
 
         // Read policies
         policyProcessor.readPolicies(jmsBinding, reader);
@@ -797,7 +793,7 @@
      * passes in the jmsBinding model.
      * The older validate() now calls validate(JMSBinding jmsBinding) with a null model. 
      */
-    public void validate() throws JMSBindingException {
+    public void validate() {
         validate( null );
     }
     
@@ -811,12 +807,7 @@
      * @param jmsBinding an optional JMS binding model to check for validity.  
      * @since 1.4
      */
-    protected void validate( JMSBinding jmsBinding ) {
-        // Check validation message for issues that arise from parsing errors.
-        if ( validationMessage != null ) {
-            throw new JMSBindingException( validationMessage );
-        }
-        
+    protected void validate( JMSBinding jmsBinding ) {        
         // If no JMSBinding model is provided, that is all the validation we can do.
         if ( jmsBinding == null ) {
             return;
@@ -859,11 +850,6 @@
         }
 
         // Other jmsBinding model validation may be added here.
-        
-        // Check validation message for issues that arise from internal model validation errors.
-        if ( validationMessage != null ) {
-            throw new JMSBindingException( validationMessage );
-        }
 
     }