You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2009/11/15 15:11:28 UTC

DO NOT REPLY [Bug 48198] New: Changes in apache rc script conflicts with FIB patch of rc.subr

https://issues.apache.org/bugzilla/show_bug.cgi?id=48198

           Summary: Changes in apache rc script conflicts with FIB patch
                    of rc.subr
           Product: Apache httpd-2
           Version: 2.2.11
          Platform: PC
        OS/Version: FreeBSD
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Core
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: eugen.konkov@kes.net.ua


Patch of rc.subr
http://server.in/softdev/fib_patch.html


in 2.2.11 you write:
[ -z "$apache22_fib" ] && apache22_fib="NO"

instead of old one:
[ -z "$apache22_fib" ] && apache22_fib="0"


That your update case a hack in rc.subr:
                      if [ "${name}_fib" && "${name}_fib" ne "NO" ]; then

instead of old one:
                      if [ "${name}_fib" ]; then


Let's guess what is better OLD or NEW form?
I think OLD form is better, becase of apache_fib="NO" really means to use FIB
by default. That is fib with '0'.

So in your script you must chech if apache_fib eq '0' or 'NO' 
then return 0 
else 
command="setfib -F ${apache22_fib} ${command}"

Are you agree?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 48198] Changes in apache rc script conflicts with FIB patch of rc.subr

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48198

Jeff Trawick <tr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |INVALID

--- Comment #3 from Jeff Trawick <tr...@apache.org> 2009-11-23 14:03:28 UTC ---
Hi Eugen,

The code you are showing is not part of Apache HTTP Server, and is not
maintained at apache.org.  This is the wrong bug reporting system for issues in
the code you quote.

As I responded earlier, that code is apparently maintained by the FreeBSD port
team.  Please find the appropriate bug reporting or discussion resources at the
FreeBSD project site.

You can find a reference to some of that code at

http://www.freshports.org/www/apache22/

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 48198] Changes in apache rc script conflicts with FIB patch of rc.subr

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48198

Eugen Konkov <eu...@kes.net.ua> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|INVALID                     |

--- Comment #2 from Eugen Konkov <eu...@kes.net.ua> 2009-11-23 13:38:20 UTC ---
gif_up() {
        # The following must be removed once RELENG_7 is branched.
        case ${gif_interfaces} in
        [Nn][Oo])
                warn "gif_interfaces=\"NO\" is deprecated, use
gif_interfaces=\"\" instead."
                gif_interfaces=""
                ;;
        esac


NO. You dont understand me. NOTICE: rc.subr code:

gif_up() {
        # The following must be removed once RELENG_7 is branched.
        case ${gif_interfaces} in
        [Nn][Oo])
                warn "gif_interfaces=\"NO\" is deprecated, use
gif_interfaces=\"\" instead."
                gif_interfaces=""
                ;;
        esac

Variable is initialized with empty string. So you also in your apache22 rc
script MUST NOT use:
line51: [ -z "$apache22_fib" ] && apache22_fib="NO"

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 48198] Changes in apache rc script conflicts with FIB patch of rc.subr

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48198

Jeff Trawick <tr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Jeff Trawick <tr...@apache.org> 2009-11-15 06:15:45 UTC ---
Hi Eugen,

That code is apparently maintained by the FreeBSD port team.  Please report it
there.  It isn't part of the Apache HTTP Server codebase.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 48198] Changes in apache rc script conflicts with FIB patch of rc.subr

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48198

Jeff Trawick <tr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


DO NOT REPLY [Bug 48198] Changes in apache rc script conflicts with FIB patch of rc.subr

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48198

Jeff Trawick <tr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org