You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/10/28 18:54:38 UTC
[GitHub] incubator-brooklyn pull request: Fix HighAvailabilityManagerSplitB...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/278
Fix HighAvailabilityManagerSplitBrainTest
Test was failing non-deterministically in various branch jenkins builds.
- If testStandbyRebind ran before testDoubleRebindFails, then the
latter would fail because TestEntityFailingRebind.throwOnRebind
had been set to false.
- Therefore always restore the value in tearDown, and set it to
true in setUp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/HighAvailabilityManagerSplitBrainTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #278
----
commit 1829cee4a1d66023f237adbf0fd1a664892c6beb
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-28T17:53:45Z
Fix HighAvailabilityManagerSplitBrainTest
- If testStandbyRebind ran before testDoubleRebindFails, then the
latter would fail because TestEntityFailingRebind.throwOnRebind
had been set to false.
- Therefore always restore the value in tearDown, and set it to
true in setUp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix HighAvailabilityManagerSplitB...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/278#issuecomment-60955546
Build failure is unrelated, and surprising.
`JmxFeedTest.setUp` failed with `Port already in use: 40126`. The test is configured to use `40123+` so it had iterated through until it had found 40126 as free and then tried to use it. Is there something else running on the same box that grabbed this port before we did? Or are tests running in parallel? Or is our `Networking.isPortAvailable` faulty? Or did our other tests in the suite leave something running in the background that grabbed the port at the same time?
Closing and re-opening to kick off jenkins again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix HighAvailabilityManagerSplitB...
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/278#issuecomment-60967877
**Static** `throwOnRebind` flag is yucky, but serviceable. This PR looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix HighAvailabilityManagerSplitB...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix HighAvailabilityManagerSplitB...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix HighAvailabilityManagerSplitB...
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/278
Fix HighAvailabilityManagerSplitBrainTest
Test was failing non-deterministically in various branch jenkins builds.
- If testStandbyRebind ran before testDoubleRebindFails, then the
latter would fail because TestEntityFailingRebind.throwOnRebind
had been set to false.
- Therefore always restore the value in tearDown, and set it to
true in setUp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/HighAvailabilityManagerSplitBrainTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #278
----
commit 1829cee4a1d66023f237adbf0fd1a664892c6beb
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-28T17:53:45Z
Fix HighAvailabilityManagerSplitBrainTest
- If testStandbyRebind ran before testDoubleRebindFails, then the
latter would fail because TestEntityFailingRebind.throwOnRebind
had been set to false.
- Therefore always restore the value in tearDown, and set it to
true in setUp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---