You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ace.apache.org by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org> on 2011/02/23 11:14:38 UTC
[jira] Created: (ACE-129) Use artifactId naming convention as used
in Felix
Use artifactId naming convention as used in Felix
-------------------------------------------------
Key: ACE-129
URL: https://issues.apache.org/jira/browse/ACE-129
Project: Ace
Issue Type: Improvement
Affects Versions: 0.8.0
Reporter: Jean-Baptiste Onofré
Assignee: Jean-Baptiste Onofré
Fix For: 0.8.0
To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
groupId: org.apache.ace
artifactId: org.apache.ace.client.automation
Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (ACE-129) Use artifactId naming convention as used
in Felix
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré resolved ACE-129.
--------------------------------------
Resolution: Fixed
Revision 1075305.
> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
> Key: ACE-129
> URL: https://issues.apache.org/jira/browse/ACE-129
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ACE-129) Use artifactId naming convention as
used in Felix
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999266#comment-12999266 ]
Jean-Baptiste Onofré commented on ACE-129:
------------------------------------------
Sorry, but I'm not sure to follow you.
The OSGi naming convention is ${groupId}/${groupId}.${artifactId}.
For instance, if you go on the central repo, you will see:
org/osgi/org.osgi.core/4.2.0
org/osgi/org.osgi.compendium/4.2.0
org/apache/felix/framework/org.apache.felix.framework/3.0.8
org/apache/karaf/admin/org.apache.karaf.admin.core/2.1.3
My purpose is to use this naming convention for groupId/artifactId in ACE.
It's just to be consistent with other OSGi projects.
> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
> Key: ACE-129
> URL: https://issues.apache.org/jira/browse/ACE-129
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ACE-129) Use artifactId naming convention as
used in Felix
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999270#comment-12999270 ]
Jean-Baptiste Onofré commented on ACE-129:
------------------------------------------
Yes, I know for the maven-bundle-plugin, it's the discuss :)
My purpose is just to change the artifactId to use the same naming convention on the maven repo.
I think it's more elegant to have:
org/apache/ace/org.apache.ace.client.automation
than
org/apache/ace/ace-client-automation
for instance.
I don't wanna change the maven-bundle-plugin itself, it's already based on the package name (not on the artifactId).
I just wanna upload clean artifactId for the first release.
> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
> Key: ACE-129
> URL: https://issues.apache.org/jira/browse/ACE-129
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ACE-129) Use artifactId naming convention as
used in Felix
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999279#comment-12999279 ]
Jean-Baptiste Onofré commented on ACE-129:
------------------------------------------
No problem Geert, we are here to discuss and decide together :)
Any agree, I'm gonna change:
- the artifactId mainly for the naming on the maven repo
- remove the Bundle-SymbolicName from the bnd (anyway, I don't wanna use the bnd file at all, I prefer to use statements in the maven bundle plugin configuration section as you mentionned in another Jira).
Let go like this :)
Thanks Geert.
> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
> Key: ACE-129
> URL: https://issues.apache.org/jira/browse/ACE-129
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (ACE-129) Use artifactId naming
convention as used in Felix
Posted by "Geert Schuring (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999264#comment-12999264 ]
Geert Schuring edited comment on ACE-129 at 2/25/11 8:37 AM:
-------------------------------------------------------------
I do not agree on this. First of all the behavior you are describing is the default for maven-bundle-plugin. See http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html
Secondly, we should stick to the maven conventions for setting groupId and artifactId and use ${groupId}.${artifactId} if the combined value is needed somewhere, exactly like the maven-bundle-plugin does.
was (Author: cathodion):
I do not agree on this. First of all the behavior you are describing is the default for maven-bundle-plugin. See http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html
Secondly, we should stick to the maven conventions for setting groupId and artifactId and use ${groupId}.${artifactId} if the combined value is needed somewhere.
> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
> Key: ACE-129
> URL: https://issues.apache.org/jira/browse/ACE-129
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ACE-129) Use artifactId naming convention as
used in Felix
Posted by "Geert Schuring (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999275#comment-12999275 ]
Geert Schuring commented on ACE-129:
------------------------------------
Sorry, my second comment was not a reaction to yours, it sounds real sarcastic this way and that was not the intention. I wrote the second comment before your response to my first comment was shown.
I understand that you want to keep in line with the naming convention used by other OSGI projects. My only point is that this is not the maven convention. But because OSGi and Maven differ on some points its ok for me to choose either one, as long as it's an explicit choice, and not some workaround to make it easy to set the bundle symbolicname while the maven-bundle-plugin does that correctly by default no mather which groupId/artifactId scheme we use.
Considering your comments I would like to suggest to use the artifactId you suggested, and to remove the Bundle-SymbolicName instruction from the bnd config since the maven-bundle-plugin's default value is equal to the artifactId you're going to use.
> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
> Key: ACE-129
> URL: https://issues.apache.org/jira/browse/ACE-129
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ACE-129) Use artifactId naming convention as
used in Felix
Posted by "Geert Schuring (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999264#comment-12999264 ]
Geert Schuring commented on ACE-129:
------------------------------------
I do not agree on this. First of all the behavior you are describing is the default for maven-bundle-plugin. See http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html
Secondly, we should stick to the maven conventions for setting groupId and artifactId and use ${groupId}.${artifactId} if the combined value is needed somewhere.
> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
> Key: ACE-129
> URL: https://issues.apache.org/jira/browse/ACE-129
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ACE-129) Use artifactId naming convention as
used in Felix
Posted by "Geert Schuring (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999267#comment-12999267 ]
Geert Schuring commented on ACE-129:
------------------------------------
... and yes, that means the Felix project is using its own plugin incorrectly if you ask me. For instance, the site mentioned in my previous comment on this issue contains the following example:
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.log</artifactId>
<packaging>bundle</packaging>
<name>Apache Felix Log Service</name>
<version>0.8.0-SNAPSHOT</version>
<build>
<plugins>
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<extensions>true</extensions>
<configuration>
<instructions>
<Export-Package>org.osgi.service.log</Export-Package>
<Private-Package>org.apache.felix.log.impl</Private-Package>
<Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
<Bundle-Activator>${pom.artifactId}.impl.Activator</Bundle-Activator>
<Export-Service>org.osgi.service.log.LogService,org.osgi.service.log.LogReaderService</Export-Service>
</instructions>
</configuration>
</plugin>
</plugins>
</build>
</project>
This may seem like a good solution, but the fact of the matter is that the following example would have the exact same result without breaking maven conventions.
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.felix</groupId>
<artifactId>felix.log</artifactId>
<packaging>bundle</packaging>
<name>Apache Felix Log Service</name>
<version>0.8.0-SNAPSHOT</version>
<build>
<plugins>
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<extensions>true</extensions>
<configuration>
<instructions>
<Export-Package>org.osgi.service.log</Export-Package>
<Private-Package>org.apache.felix.log.impl</Private-Package>
<Bundle-Activator>org.apache.felix.log.impl.Activator</Bundle-Activator>
<Export-Service>org.osgi.service.log.LogService,org.osgi.service.log.LogReaderService</Export-Service>
</instructions>
</configuration>
</plugin>
</plugins>
</build>
</project>
The maven bundle plugin will combine the groupId and artifactId into "org.apache.felix.log" as described on http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html
> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
> Key: ACE-129
> URL: https://issues.apache.org/jira/browse/ACE-129
> Project: Ace
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName of the Felix maven-bundle-plugin.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira