You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/06/09 22:35:01 UTC
[jira] [Commented] (ACCUMULO-2753) Redundancy in TServerInstance
methods
[ https://issues.apache.org/jira/browse/ACCUMULO-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025698#comment-14025698 ]
ASF subversion and git services commented on ACCUMULO-2753:
-----------------------------------------------------------
Commit ced3293b324331177f743fe0ef866af56c646e50 in accumulo's branch refs/heads/master from [~ecn]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=ced3293 ]
ACCUMULO-2753 used TServerInstance to encode mutations
> Redundancy in TServerInstance methods
> -------------------------------------
>
> Key: ACCUMULO-2753
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2753
> Project: Accumulo
> Issue Type: Sub-task
> Components: tserver
> Reporter: Bill Havanki
> Assignee: Eric Newton
> Priority: Trivial
> Labels: newbie, refactoring
>
> While perusing the metadata table code, I noticed that there is a method {{TServerInstance.putFutureLocation(Mutation)}}, but logic in {{MetaDataStateStore.setFutureLocations(Collection<Assignment>)}} doesn't use it. Either the code should be refactored properly or the {{TServerInstance}} method should be eliminated.
> From this, the rest of the methods in {{TServerInstance}} should be checked to see if they are used and useful, and refactoring done as appropriate.
--
This message was sent by Atlassian JIRA
(v6.2#6252)