You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/29 11:53:14 UTC
[GitHub] [hive] losipiuk opened a new pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
losipiuk opened a new pull request #2129:
URL: https://github.com/apache/hive/pull/2129
This is a cherry-pick of #2040 (https://issues.apache.org/jira/browse/HIVE-24851) to branch-3.1
Followup after cherry-pick to `branch-3` from https://github.com/apache/hive/pull/2104.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] losipiuk commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
losipiuk commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-812918795
> > @pvary it looks CI failed. How can I check if that is related (I very much doubt that)
>
> I am not entirely sure. Either we can ask on the dev list, or we can run a test with a "null" change, and see the test results there as well.
I added "empty" commit. Let's see if it will trigger CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] findepi commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
findepi commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-813594793
@pvary can you please help diagnose the build results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] losipiuk commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
losipiuk commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-822290914
Based on 3 runs it looks like all the test failures are flakes. Same tests (which FWIW seem totally unrelated to the change) fail on on run and pass on the other.
* (1) http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-2129/1/tests/
* Only preexisting failures
* (2) http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-2129/2/tests/
* TestSlotZnode.testConcurrencyNoFallback failed (green on (1) and (3))
* TestSlotZnode.testConcurrencyAndFallback failed (green on (1) and (3))
* (3) http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-2129/3/tests/
* TestJdbcDriver2.testSelectExecAsync2 failed (was green on (2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] losipiuk commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
losipiuk commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-822291962
@pvary mergable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] losipiuk commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
losipiuk commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-810578166
@pvary it looks CI failed. How can I check if that is related (I very much doubt that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] losipiuk commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
losipiuk commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-809316902
@pvary this is the last one. I promise :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-809319344
> @pvary this is the last one. I promise :)
Never say never 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-810802965
> @pvary it looks CI failed. How can I check if that is related (I very much doubt that)
I am not entirely sure. Either we can ask on the dev list, or we can run a test with a "null" change, and see the test results there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-822301658
Merged.
Thanks for the fix and the work done to backport the change @losipiuk!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #2129:
URL: https://github.com/apache/hive/pull/2129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #2129: Backport HIVE-24851: Fix reader leak in AvroGenericRecordReader to branch-3.1
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #2129:
URL: https://github.com/apache/hive/pull/2129#issuecomment-814638355
> @pvary can you please help diagnose the build results?
I would go to the failure list, and ignore the ones which are failing in both patches. I see 1 fixed (most important to check), and 2 new failures (less important but I would check anyway). If the failures are flaky or green on local. Then I would push again my changes and hope for a "green" run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org