You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stephen Coy (JIRA)" <ji...@codehaus.org> on 2010/09/22 02:02:32 UTC
[jira] Created: (MWAR-237) packagingIncludes configuration has
disappeared
packagingIncludes configuration has disappeared
-----------------------------------------------
Key: MWAR-237
URL: http://jira.codehaus.org/browse/MWAR-237
Project: Maven 2.x WAR Plugin
Issue Type: Bug
Affects Versions: 2.1
Environment: 2.2.1, 3.0RC1
Reporter: Stephen Coy
Priority: Blocker
The packagingIncludes configuration element has completely disappeared from this plugin.
This not only breaks our "skinny-war" build, it also invalidates the documentation at <http://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-237) packagingIncludes configuration has
disappeared
Posted by "Stephen Coy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236039#action_236039 ]
Stephen Coy commented on MWAR-237:
----------------------------------
Isn't the plugin documentation generated from the source? It does not appear on <http://maven.apache.org/plugins/maven-war-plugin/war-mojo.html>. This is what makes me think it has disappeared. Furthermore, it works fine using 2.1-beta-1.
The only practical work around is to downgrade, hence the blocker.
In any event, here is the plugin configuration:
<plugin>
<artifactId>maven-war-plugin</artifactId>
<configuration>
<archive>
<!-- exclude maven pom from generated war -->
<addMavenDescriptor>false</addMavenDescriptor>
</archive>
<webResources>
<resource>
<filtering>true</filtering>
<directory>src/main/webapp</directory>
<includes>
<include>MessageResources.properties</include>
</includes>
</resource>
</webResources>
</configuration>
<executions>
<execution>
<id>default-war</id>
<phase>package</phase>
<goals>
<goal>war</goal>
</goals>
</execution>
<execution>
<id>slim-war</id>
<phase>package</phase>
<goals>
<goal>war</goal>
</goals>
<configuration>
<classifier>slim</classifier>
<packagingIncludes>
fusioncharts/**/*,
fusionwidgets/**/*,
global-theme/**/*,
home.do,
images/**/*,
META-INF/**/*,
scripts/**/*,
WEB-INF/classes/**/*,
WEB-INF/config/**/*,
WEB-INF/**/*.xml,
WEB-INF/jsp/**/*,
WEB-INF/lib/sitemesh*.jar,
WEB-INF/lib/struts*.jar,
WEB-INF/lib/json-lib*.jar,
WEB-INF/lib/ezmorph*.jar,
WEB-INF/lib/displaytag*.jar,
WEB-INF/lib/commons-fileupload*.jar,
WEB-INF/tlds/**/*
</packagingIncludes>
</configuration>
</execution>
</executions>
</plugin>
> packagingIncludes configuration has disappeared
> -----------------------------------------------
>
> Key: MWAR-237
> URL: http://jira.codehaus.org/browse/MWAR-237
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: 2.2.1, 3.0RC1
> Reporter: Stephen Coy
> Assignee: Stephane Nicoll
> Priority: Minor
>
> The packagingIncludes configuration element has completely disappeared from this plugin.
> This not only breaks our "skinny-war" build, it also invalidates the documentation at <http://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-237) packagingIncludes configuration has
disappeared
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236089#action_236089 ]
Dennis Lundberg commented on MWAR-237:
--------------------------------------
You are right, my mistake.
There should be an empty @parameter annotation for that parameter, like this:
{noformat}
*
* @parameter
* @since 2.1-beta-1
*/
private String packagingIncludes;
{noformat}
> packagingIncludes configuration has disappeared
> -----------------------------------------------
>
> Key: MWAR-237
> URL: http://jira.codehaus.org/browse/MWAR-237
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: 2.2.1, 3.0RC1
> Reporter: Stephen Coy
> Assignee: Dennis Lundberg
> Priority: Minor
>
> The packagingIncludes configuration element has completely disappeared from this plugin.
> This not only breaks our "skinny-war" build, it also invalidates the documentation at <http://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-237) packagingIncludes configuration has
disappeared
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephane Nicoll updated MWAR-237:
---------------------------------
Priority: Minor (was: Blocker)
Assignee: Stephane Nicoll
easy with the blocker priority, especially with that amount of details. PackagingIncludes is there.
That being said, it is impossible to figure out what could be wrong in your setup since you did not provide any way to reproduce (pom sample, project to reproduce, logs)
Come on.
> packagingIncludes configuration has disappeared
> -----------------------------------------------
>
> Key: MWAR-237
> URL: http://jira.codehaus.org/browse/MWAR-237
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: 2.2.1, 3.0RC1
> Reporter: Stephen Coy
> Assignee: Stephane Nicoll
> Priority: Minor
>
> The packagingIncludes configuration element has completely disappeared from this plugin.
> This not only breaks our "skinny-war" build, it also invalidates the documentation at <http://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MWAR-237) packagingIncludes
configuration has disappeared
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236040#action_236040 ]
Stephane Nicoll edited comment on MWAR-237 at 9/22/10 2:07 AM:
---------------------------------------------------------------
Dennis,
I see a weird change on the packagingIncludes parameter in one of your commit
http://svn.apache.org/viewvc?view=revision&revision=985625
Could you please have a look?
Thx
was (Author: sni):
Denis,
I see a weird change on the packagingIncludes parameter in one of your commit
http://svn.apache.org/viewvc?view=revision&revision=985625
Could you please have a look?
Thx
> packagingIncludes configuration has disappeared
> -----------------------------------------------
>
> Key: MWAR-237
> URL: http://jira.codehaus.org/browse/MWAR-237
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: 2.2.1, 3.0RC1
> Reporter: Stephen Coy
> Assignee: Dennis Lundberg
> Priority: Minor
>
> The packagingIncludes configuration element has completely disappeared from this plugin.
> This not only breaks our "skinny-war" build, it also invalidates the documentation at <http://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MWAR-237) packagingIncludes configuration has
disappeared
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MWAR-237.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.2
Fixed in [r1000203|http://svn.apache.org/viewvc?view=revision&revision=1000203].
> packagingIncludes configuration has disappeared
> -----------------------------------------------
>
> Key: MWAR-237
> URL: http://jira.codehaus.org/browse/MWAR-237
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: 2.2.1, 3.0RC1
> Reporter: Stephen Coy
> Assignee: Dennis Lundberg
> Priority: Minor
> Fix For: 2.2
>
>
> The packagingIncludes configuration element has completely disappeared from this plugin.
> This not only breaks our "skinny-war" build, it also invalidates the documentation at <http://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-237) packagingIncludes configuration has
disappeared
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MWAR-237:
---------------------------------
Fix Version/s: (was: 2.2)
2.1.1
> packagingIncludes configuration has disappeared
> -----------------------------------------------
>
> Key: MWAR-237
> URL: http://jira.codehaus.org/browse/MWAR-237
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: 2.2.1, 3.0RC1
> Reporter: Stephen Coy
> Assignee: Dennis Lundberg
> Priority: Minor
> Fix For: 2.1.1
>
>
> The packagingIncludes configuration element has completely disappeared from this plugin.
> This not only breaks our "skinny-war" build, it also invalidates the documentation at <http://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MWAR-237) packagingIncludes
configuration has disappeared
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236040#action_236040 ]
Stephane Nicoll edited comment on MWAR-237 at 9/22/10 2:08 AM:
---------------------------------------------------------------
Dennis,
I see a weird change on the packagingIncludes parameter in one of your commit
http://svn.apache.org/viewvc?view=revision&revision=985625
In particular:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/WarMojo.java?r1=985595&r2=985625&pathrev=985625
Could you please have a look?
Thx
was (Author: sni):
Dennis,
I see a weird change on the packagingIncludes parameter in one of your commit
http://svn.apache.org/viewvc?view=revision&revision=985625
Could you please have a look?
Thx
> packagingIncludes configuration has disappeared
> -----------------------------------------------
>
> Key: MWAR-237
> URL: http://jira.codehaus.org/browse/MWAR-237
> Project: Maven 2.x WAR Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Environment: 2.2.1, 3.0RC1
> Reporter: Stephen Coy
> Assignee: Dennis Lundberg
> Priority: Minor
>
> The packagingIncludes configuration element has completely disappeared from this plugin.
> This not only breaks our "skinny-war" build, it also invalidates the documentation at <http://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html>.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira