[GitHub] whanice edited a comment on issue #1841: I am confused with config server, transporter config.

[GitBox <gi...@apache.org>]

whanice edited a comment on issue #1841: I am confused with config server,  transporter config.
URL: https://github.com/apache/incubator-dubbo/issues/1841#issuecomment-402902957
 
 
   Thanks for your guys reply.
   Surely. the tcp connection should not be related to the nio framework,  No matter what you use, netty3, netty4 or mina in server. Will not affect the client use. 
   
   I care about migration.   when consumer use dubbo-2.5.x .  not have netty4 extension.
   when provider  wants to upgrade dubbo verison to dubbo-2.6.x and use netty4. It will affect the consumer.  
   
   So I think in `DubboProtol.initClient`.  change to  this will be better.
   ```
    // client type setting.
       String str = url.getParameter(Constants.CLIENT_KEY, url.getParameter(Constants.TRANSPORTER_KEY, Constants.DEFAULT_REMOTING_CLIENT));
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org