[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1892: [split/17] move the rest of physical expr to datafusion-physical-expr crate

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1892:
URL: https://github.com/apache/arrow-datafusion/pull/1892#discussion_r816113139



##########
File path: datafusion/Cargo.toml
##########
@@ -40,9 +40,9 @@ path = "src/lib.rs"
 [features]
 default = ["crypto_expressions", "regex_expressions", "unicode_expressions"]
 simd = ["arrow/simd"]
-crypto_expressions = ["md-5", "sha2", "blake2", "blake3"]
-regex_expressions = ["regex"]
-unicode_expressions = ["unicode-segmentation"]
+crypto_expressions = [ "datafusion-physical-expr/crypto_expressions" ]
+unicode_expressions = ["datafusion-physical-expr/regex_expressions"]
+regex_expressions = ["datafusion-physical-expr/regex_expressions"]

Review comment:
       👍 

##########
File path: datafusion/src/physical_plan/aggregate_rule.rs
##########
@@ -17,249 +17,9 @@
 
 //! Support the coercion rule for aggregate function.
 
-use arrow::datatypes::DataType;
-use arrow::datatypes::Schema;
-use datafusion_common::{DataFusionError, Result};
-use datafusion_expr::AggregateFunction;
-use datafusion_expr::{Signature, TypeSignature};
-use datafusion_physical_expr::expressions::is_approx_percentile_cont_supported_arg_type;
-use datafusion_physical_expr::expressions::{
-    is_avg_support_arg_type, is_correlation_support_arg_type,
-    is_covariance_support_arg_type, is_stddev_support_arg_type, is_sum_support_arg_type,
-    is_variance_support_arg_type, try_cast,
+pub use datafusion_physical_expr::coercion_rule::aggregate_rule::{

Review comment:
       yeah as a follow on we can maybe consolidate a bit more. This is good for now 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org