You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by "matthewt-assurity (via GitHub)" <gi...@apache.org> on 2023/05/29 03:37:11 UTC

[GitHub] [jmeter] matthewt-assurity opened a new pull request, #5947: Update HTML parser to pick up `preload` attribute for `rel`

matthewt-assurity opened a new pull request, #5947:
URL: https://github.com/apache/jmeter/pull/5947

   ## Description
   Updated JMeter HTML parsers to pick up on the `preload` value for the `rel` attribute in `<link>` tags.
   
   A constant has been added to `HTMLParser.java` for the preload value. The parser implementation classes have been updated to use this constant.
   
   ## Motivation and Context
   During a project we found some embedded resource files that were not being downloaded by default. To address this in the meantime we have used the parallel sampler extension. We found that the problem was the `preload` value wasn't being picked up as a valid value in the JMeter HTML parsers, so I am proposing that this becomes part of the HTML parsers.
   
   I am unaware of any open issue for this.
   
   ## How Has This Been Tested?
   `./gradlew runGui` has been run, and a simple test hitting an HTML page with `rel=preload` attributes was run. 
   
   `./gradlew check` has been run and passes.
   
   ## Types of changes
   - New feature (non-breaking change which adds functionality)
   
   ## Checklist:
   - [x ] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] vlsi closed pull request #5947: Update HTML parser to pick up `preload` attribute for `rel`

Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi closed pull request #5947: Update HTML parser to pick up `preload` attribute for `rel`
URL: https://github.com/apache/jmeter/pull/5947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] vlsi commented on pull request #5947: Update HTML parser to pick up `preload` attribute for `rel`

Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5947:
URL: https://github.com/apache/jmeter/pull/5947#issuecomment-1576942482

   Merged in https://github.com/apache/jmeter/commit/6d6479ba7a387a4bd9de4759f595dbcf9d644101


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] matthewt-assurity commented on pull request #5947: Update HTML parser to pick up `preload` attribute for `rel`

Posted by "matthewt-assurity (via GitHub)" <gi...@apache.org>.
matthewt-assurity commented on PR #5947:
URL: https://github.com/apache/jmeter/pull/5947#issuecomment-1566461336

   This is my first time contributing to JMeter, is there any documentation that should be updated for this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] vlsi commented on pull request #5947: Update HTML parser to pick up `preload` attribute for `rel`

Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5947:
URL: https://github.com/apache/jmeter/pull/5947#issuecomment-1572668903

   Do you think you could update https://github.com/apache/jmeter/blob/master/xdocs/changes.xml as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org