You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by afine <gi...@git.apache.org> on 2017/04/28 19:56:41 UTC

[GitHub] zookeeper pull request #245: ZOOKEEPER-2750: Document SSL Support for Atomic...

GitHub user afine opened a pull request:

    https://github.com/apache/zookeeper/pull/245

    ZOOKEEPER-2750: Document SSL Support for Atomic Broadcast protocol

    This patch depends on ZOOKEEPER-236: SSL Support for Atomic Broadcast protocol (https://github.com/apache/zookeeper/pull/184), hence the large diff. 
    
    This patch focuses on `zookeeperAdmin.xml` which documents the various new system properties associated with ZOOKEEPER-236. More documentation is in the works and a document with the suggested changes to the wiki will be linked here in the future.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2750

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #245
    
----
commit 2ab6c5e1b950c42c1be8d4f6c2bb0c98666e3a36
Author: Abraham Fine <af...@apache.org>
Date:   2017-03-06T23:12:59Z

    ZOOKEEPER-236: SSL Support for Atomic Broadcast protocol

commit 54d2f1093b69a4d884f0681d827e5cacdc87a99c
Author: Abraham Fine <af...@apache.org>
Date:   2017-03-14T17:56:03Z

    hostname verification

commit a1ac5dbb204ad4e3c7c27f2a3bb5906f7e2bf7bf
Author: Abraham Fine <af...@apache.org>
Date:   2017-03-14T22:27:05Z

    certificate revocation checking

commit 10b580dd7a8781e02dce44f5d021d62105d1d09e
Author: Abraham Fine <af...@apache.org>
Date:   2017-03-17T22:18:47Z

    cleaner hostname verification

commit f1a9ff957c01c9e5e8498e3ad75c1fb6a3670278
Author: Abraham Fine <af...@apache.org>
Date:   2017-03-20T22:43:55Z

    cleaner hostname verification

commit aed9c01f90a68dbb7b396820d755a2389ee14be8
Author: Abraham Fine <af...@apache.org>
Date:   2017-03-24T21:24:58Z

    more cleanup and switch to hostname verifier from apache httpcomponents

commit 1909286f584d5d6b3f423430118da6ce6eb3501f
Author: Abraham Fine <af...@apache.org>
Date:   2017-03-31T22:46:32Z

    add testing

commit c564ce839e2823dd69bfab8d26aed6c7284f2025
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-04T03:01:33Z

    OCSP test working

commit 3983a66199da294a491b20f55b1ae23278a27925
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-04T03:28:11Z

    support passwordless truststores
    fix Zab1_0Test

commit ae165f63204a1af1b979037b3692bfc25d2f09c0
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-04T22:31:56Z

    UnifiedServerSocketTests and X509Util tests

commit 0396ac3403ccce8d04ece2be9962f8d102e936cb
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-06T02:27:07Z

    move X509UtilTest to the proper directory
    unneeded remove QuorumServer changes

commit 735b58b131ad65cf661c69375ce5fb39a1470ab2
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-06T02:53:37Z

    remove unnecessary instantiation of X509Util in the learner

commit 6babcd56e81a64266479b887ed20d5aba4ef8f14
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-06T20:41:28Z

    change hostname verification to attempt just using the ip address before
    trying reverse dns

commit 513439467230fb48a0ebeaa6fe6b93da2c3daf2c
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-06T21:40:20Z

    reduce flakyness in UnifiedServerSocketTest

commit 8fca7d6b9391df672d1679a9dbb9ce6102f2af1f
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-06T21:44:32Z

    replace magic numbers UnifiedServerSocketTest

commit 8fd892d1bbe51c8c50c585c1c9348e6bd5776ac6
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-07T19:45:25Z

    fix findbugs warnings

commit c00956aa2734a2c383961b5b3a6f2fd28f5715e5
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-07T22:10:17Z

    pull out zktrustmanager and add testing

commit 6f0f0696e6778fdc9bce1c2bd794108d7f4152f3
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-13T22:27:31Z

    Add comments regarding SunX509 to PKIX change
    Add integration tests for tls cipher suites and protocol versions
    Claify ZKTrustManager
    Remove ssl socket creation code from UnifiedServerSocket
    HostnameVerification now on by default

commit ff5ec577eb8204fc675dc8a9f0fc65e8ead48271
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-14T17:19:22Z

    Address stylistic comments from hanm's review
    Clean up exception handling

commit 30090f7e166a7da80841c40893bec635d4385aac
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-14T22:38:34Z

    Attempt to fix flaky test

commit 1a20d14929b7427e51791bba3d40ead7853d44ca
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-19T20:55:34Z

    look for stuck thread in tests

commit 3c6c81b69b7105fa7c5235a0f27718a7eae195de
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-20T19:19:33Z

    Make sure to close underlying socket when closing ssl socket

commit 08d29810aae233807f22a6adb5f797fb810807df
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-20T23:09:30Z

    reduce concurrent tests for debugging

commit 8686df4143988d484443344edc260d55620cd209
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-21T18:37:52Z

    revert scripts, change implementation for rolling upgrade socket

commit a95bb9232facc9e67646c9cad2610277fa2177ad
Author: Abraham Fine <af...@apache.org>
Date:   2017-04-28T19:51:06Z

    ZOOKEEPER-2750: Document SSL Support for Atomic Broadcast protocol

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #245: ZOOKEEPER-2750: Document SSL Support for Atomic Broadc...

Posted by afine <gi...@git.apache.org>.

Github user afine commented on the issue:

    https://github.com/apache/zookeeper/pull/245
  
    @hanm my plan was to wait until 184 gets merged and then rebase. Let me know if that is a problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #245: ZOOKEEPER-2750: Document SSL Support for Atomic Broadc...

Posted by hanm <gi...@git.apache.org>.

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/245
  
    >> This patch depends on ZOOKEEPER-236: SSL Support for Atomic Broadcast protocol (#184), hence the large diff.
    
    You can generate a pull request on top of the branch-35 which only contains diffs for doc. As long as your working branch for pull request 184 has same doc as branch-3.5 this pull request should be able to merge (once after 184 merged) without any conflicts. That would make this pr easy to review, and avoid any potential merging problems later when 184 is merged. Other options: close this PR and add doc change to pr 184. Or wait until 184 gets merged then rebase and update this pr.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---