You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/03/30 14:03:10 UTC
Review Request 58076: Cleanup unused files and data in ambari-agent
code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58076/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-20634
https://issues.apache.org/jira/browse/AMBARI-20634
Repository: ambari
Description
-------
Diffs
-----
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py cf48189
ambari-agent/src/main/python/ambari_agent/ProcessHelper.py bc2f827
ambari-agent/src/main/python/ambari_agent/StatusCheck.py 5231f72
ambari-agent/src/main/python/ambari_agent/main.py 923c570
ambari-agent/src/test/python/ambari_agent/TestMain.py a04b85d
ambari-agent/src/test/python/ambari_agent/TestProcessHelper.py f30d45d
ambari-agent/src/test/python/ambari_agent/TestStatusCheck.py 34c57cc
Diff: https://reviews.apache.org/r/58076/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58076: Cleanup unused files and data in
ambari-agent code
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58076/#review170632
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/main.py
Line 92 (original), 92 (patched)
<https://reviews.apache.org/r/58076/#comment243506>
import needs to be removed, too
- Attila Doroszlai
On March 30, 2017, 4:03 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58076/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 4:03 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20634
> https://issues.apache.org/jira/browse/AMBARI-20634
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py cf48189
> ambari-agent/src/main/python/ambari_agent/ProcessHelper.py bc2f827
> ambari-agent/src/main/python/ambari_agent/StatusCheck.py 5231f72
> ambari-agent/src/main/python/ambari_agent/main.py 923c570
> ambari-agent/src/test/python/ambari_agent/TestMain.py a04b85d
> ambari-agent/src/test/python/ambari_agent/TestProcessHelper.py f30d45d
> ambari-agent/src/test/python/ambari_agent/TestStatusCheck.py 34c57cc
>
>
> Diff: https://reviews.apache.org/r/58076/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58076: Cleanup unused files and data in
ambari-agent code
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58076/#review170577
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 30, 2017, 2:03 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58076/
> -----------------------------------------------------------
>
> (Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 30, 2017, 2:03 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20634
> https://issues.apache.org/jira/browse/AMBARI-20634
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py cf48189
> ambari-agent/src/main/python/ambari_agent/ProcessHelper.py bc2f827
> ambari-agent/src/main/python/ambari_agent/StatusCheck.py 5231f72
> ambari-agent/src/main/python/ambari_agent/main.py 923c570
> ambari-agent/src/test/python/ambari_agent/TestMain.py a04b85d
> ambari-agent/src/test/python/ambari_agent/TestProcessHelper.py f30d45d
> ambari-agent/src/test/python/ambari_agent/TestStatusCheck.py 34c57cc
>
>
> Diff: https://reviews.apache.org/r/58076/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>