You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/07/02 02:55:12 UTC
[PR] feat(i18n): backfill French (fr) translations (AI-generated, needs review) [superset]
rusackas opened a new pull request, #41655:
URL: https://github.com/apache/superset/pull/41655
### SUMMARY
Backfills the remaining untranslated entries in the French (`fr`) catalog using `scripts/translations/backfill_po.py` (Claude, cross-language context), **skipping do-not-translate tokens** (icon names, enum values, SQL keywords, API field names, placeholders — see #41651).
All generated strings are marked `#, fuzzy` with an attribution comment. The `#, fuzzy` flag marks each entry as machine-generated and needing native-speaker review. **Note on serving:** both the frontend (`po2json --fuzzy`) and backend (`pybabel compile --use-fuzzy`, see #41648) builds include fuzzy entries, so these translations render in the UI once built — reviewers should verify each and remove the `#, fuzzy` flag to confirm. Format placeholders are preserved (verified programmatically).
Tracked by `check_translation_regression.py` as `untranslated → fuzzy`, which is explicitly **not** a regression. Part of a per-language sweep.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Translation catalog only — no layout or behavior change. Strings render once the frontend/backend are rebuilt.
### TESTING INSTRUCTIONS
- `pybabel compile --use-fuzzy -d superset/translations -l fr` succeeds.
- French native speakers: review the `#, fuzzy` entries and de-fuzz once confirmed.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill French (fr) translations (AI-generated, needs review) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41655:
URL: https://github.com/apache/superset/pull/41655#issuecomment-4861761065
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill French (fr) translations (AI-generated, needs review) [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41655:
URL: https://github.com/apache/superset/pull/41655#issuecomment-4861777141
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41655?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.84%. Comparing base ([`748060d`](https://app.codecov.io/gh/apache/superset/commit/748060d35e74724d13f64af205f2c2b3a0290118?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a080e30`](https://app.codecov.io/gh/apache/superset/commit/a080e3074ba4cc11d55e40f3965cf8e66a7e9474?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (748060d) and HEAD (a080e30). Click for more details.
>
> <details><summary>HEAD has 45 uploads less than BASE</summary>
>
>| Flag | BASE (748060d) | HEAD (a080e30) |
>|------|------|------|
>|python|37|2|
>|presto|6|1|
>|hive|6|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #41655 +/- ##
==========================================
- Coverage 64.63% 55.84% -8.79%
==========================================
Files 2674 2674
Lines 147711 147711
Branches 34098 34098
==========================================
- Hits 95466 82493 -12973
- Misses 50509 64471 +13962
+ Partials 1736 747 -989
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/41655/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/41655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.10% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/41655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/41655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/41655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.64% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/41655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.70% <ø> (-18.61%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/41655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/41655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41655?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill French (fr) translations (AI-generated, needs review) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #41655:
URL: https://github.com/apache/superset/pull/41655#discussion_r3510235319
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -6234,9 +6452,11 @@ msgstr ""
msgid "Error deleting %s"
msgstr "Une erreur s'est produite durant la récupération des données : %s"
-#, python-format
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, es, sr,
+# sr_Latn]
+#, fuzzy, python-format
msgid "Error disabling fullscreen: %s"
-msgstr ""
+msgstr "Erreur lors de la désactivation du plein écran : %s"
#, fuzzy, python-format
msgid "Error enabling fullscreen: %s"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong translation for Error enabling fullscreen</b></div>
<div id="fix">
The msgstr for `Error enabling fullscreen: %s` duplicates the translation of `Error deleting %s` ("Une erreur s'est produite durant la récupération des données"), which means "error fetching data" — entirely wrong for an enabling-fullscreen action. It also mismatches the adjacent `Error disabling fullscreen: %s` translation at line 6458 ("Erreur lors de la désactivation du plein écran"). The correct translation is "Erreur lors de l'activation du plein écran : %s".
</div>
</div>
<small><i>Code Review Run #953ee6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -6030,15 +6227,21 @@ msgstr "Activer les prévisions"
msgid "Enable graph roaming"
msgstr "Activer le déplacement graphique"
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja,
+# lv, pt_BR, ru, sk, sr, sr_Latn, tr, uk]
+#, fuzzy
msgid "Enable icon JavaScript mode"
-msgstr ""
+msgstr "Activer le mode JavaScript pour les icônes"
#, fuzzy
msgid "Enable icons"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong translation for Enable icons</b></div>
<div id="fix">
The msgstr for `Enable icons` reads "Colonnex du tableau" (literally "Table columns"), which is an unrelated error from a prior human translator. The new backfill translation correctly translated the adjacent `Enable icon JavaScript mode` as "Activer le mode JavaScript pour les icônes" but missed this entry. The correct French for "Enable icons" is "Activer les icônes".
</div>
</div>
<small><i>Code Review Run #953ee6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -6510,8 +6733,11 @@ msgstr "Échec de l'export, veuillez réessayer."
msgid "Export failed: %s"
msgstr "Rapport échoué"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing printf placeholder in translation</b></div>
<div id="fix">
The msgid "Export failed: %s" has a `#, fuzzy, python-format` flag, but the msgstr is missing the %s placeholder. The usage at `superset-frontend/src/SqlLab/components/ResultSet/index.tsx:243` calls `addDangerToast(t('Export failed: %s', error))`, passing error as a substitution argument. At runtime, the error detail will be silently dropped, producing "Rapport échoué" instead of the intended "Rapport échoué: <actual error>".
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
msgstr "Échec de l'exportation : %s"
````
</div>
</details>
</div>
<small><i>Code Review Run #953ee6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -8680,8 +8983,11 @@ msgstr "Mapbox"
msgid "Mapbox (API key required)"
msgstr "le courriel est obligatoire"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Cross-contaminated translation</b></div>
<div id="fix">
The msgstr for `"Mapbox (API key required)"` reads "le courriel est obligatoire" (email is mandatory), which has no semantic relation to the English source. This is a cross-contamination from a different source string. Fix: "Mapbox (clé API requise)".
</div>
</div>
<small><i>Code Review Run #953ee6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org