You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2025/11/06 23:24:08 UTC
[PR] Fix double redirection while authenticating in Fab auth manager [airflow]
vincbeck opened a new pull request, #57993:
URL: https://github.com/apache/airflow/pull/57993
When you authenticate with Fab auth manager, a double redirection happens. After logging in, you are first redirected to the Airflow home page, Airflow considers you as unauthenticated, redirects you to the login page which then redirect you to the home page authenticated.
I think there was a change in Fab when we migrated to Fab 5 because before, after logging-in you were redirected to `/auth` which then handled the cookie for you. Now, the user gets redirected automatically to Airflow homepage, which is better, but we did not handle that when we migrated.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double redirection while authenticating with Fab auth manager [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #57993:
URL: https://github.com/apache/airflow/pull/57993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double redirection while authenticating with Fab auth manager [airflow]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #57993:
URL: https://github.com/apache/airflow/pull/57993#discussion_r2501207794
##########
providers/fab/src/airflow/providers/fab/www/views.py:
##########
@@ -122,6 +109,23 @@
return redirect_url.geturl()
+def redirect(*args, **kwargs):
+ if g.user is not None and g.user.is_authenticated:
+ token = get_auth_manager().generate_jwt(g.user)
+ response = make_response(flask_redirect(*args, **kwargs))
+
+ secure = request.scheme == "https" or bool(conf.get("api", "ssl_cert", fallback=""))
+ # In Airflow 3.1.1 authentication changes, front-end no longer handle the token
+ # See https://github.com/apache/airflow/pull/55506
+ if AIRFLOW_V_3_1_1_PLUS:
+ response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=secure, httponly=True)
+ else:
+ response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=secure)
Review Comment:
## Failure to use secure cookies
Cookie is added without the HttpOnly attribute properly set.
[Show more details](https://github.com/apache/airflow/security/code-scanning/545)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org