[GitHub] [arrow] lidavidm commented on a diff in pull request #35353: GH-35352: [Java] Fix issues with "semi complex" types.

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #35353:
URL: https://github.com/apache/arrow/pull/35353#discussion_r1187536473


##########
java/vector/src/main/codegen/templates/ComplexWriters.java:
##########
@@ -191,7 +195,9 @@ public void writeNull() {
 public interface ${eName}Writer extends BaseWriter {
   public void write(${minor.class}Holder h);
 
-  <#if minor.class?starts_with("Decimal")>@Deprecated</#if>
+<#if minor.class?starts_with("Decimal") || is_timestamp_tz(minor.class) || minor.class == "Duration" || minor.class == "FixedSizeBinary">
+  @Deprecated

Review Comment:
   Is it possible to generate a basic JavaDoc with a `@deprecated` tag with a little more context?



##########
java/vector/src/test/java/org/apache/arrow/vector/TestListVector.java:
##########
@@ -898,6 +903,120 @@ public void testWriterGetField() {
     }
   }
 
+  @Test
+  public void testWriterGetTimestampMilliTZField() {
+    try (final ListVector vector = ListVector.empty("list", allocator)) {
+      org.apache.arrow.vector.complex.writer.FieldWriter writer = vector.getWriter();
+      writer.allocate();
+
+      writer.startList();
+      writer.timeStampMilliTZ().writeTimeStampMilliTZ(1000L);
+      writer.timeStampMilliTZ().writeTimeStampMilliTZ(2000L);
+      writer.endList();
+      vector.setValueCount(2);

Review Comment:
   while not relevant to the test, the list vector has only one value here right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org