You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2025/02/13 03:52:46 UTC

[I] [Bug] Race condition when using the prefetchableClientReadHandler [incubator-uniffle]

zuston opened a new issue, #2369:
URL: https://github.com/apache/incubator-uniffle/issues/2369

   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [x] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the bug
   
   ![Image](https://github.com/user-attachments/assets/1fe9ae74-cb6e-4bef-b87c-ff58384aa00b)
   
   The bug happens on the code.https://github.com/apache/incubator-uniffle/blob/124a9015835bf30e47bb16d584b065bea06f01e9/storage/src/main/java/org/apache/uniffle/storage/handler/impl/DataSkippableReadHandler.java#L90-L110
   
   The `processedBlockId` will be modified in the ShuffleReadClientImpl at the same time.
   
   If so, we have to use synchronize to lock all related `processBlockId` operations.
   
   ### Affects Version(s)
   
   master
   
   ### Uniffle Server Log Output
   
   ```logtalk
   
   ```
   
   ### Uniffle Engine Log Output
   
   ```logtalk
   
   ```
   
   ### Uniffle Server Configurations
   
   ```yaml
   
   ```
   
   ### Uniffle Engine Configurations
   
   ```yaml
   
   ```
   
   ### Additional context
   
   cc @jerqi 
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [I] [Bug] Race condition when using the prefetchableClientReadHandler [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #2369:
URL: https://github.com/apache/incubator-uniffle/issues/2369#issuecomment-2680305626

   > cc [@jerqi](https://github.com/jerqi) Do you have any ideas on this?
   
   Maybe we can use concurrentHashMap instead of bitmap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [I] [Bug] Race condition when using the prefetchableClientReadHandler [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #2369:
URL: https://github.com/apache/incubator-uniffle/issues/2369#issuecomment-2655423864

   cc @jerqi Do you have any ideas on this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [I] [Bug] Race condition when using the prefetchableClientReadHandler [incubator-uniffle]

Posted by "summaryzb (via GitHub)" <gi...@apache.org>.
summaryzb commented on issue #2369:
URL: https://github.com/apache/incubator-uniffle/issues/2369#issuecomment-2696317661

   This is fixed by #2368


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [I] [Bug] Race condition when using the prefetchableClientReadHandler [uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed issue #2369: [Bug] Race condition when using the prefetchableClientReadHandler
URL: https://github.com/apache/uniffle/issues/2369


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [I] [Bug] Race condition when using the prefetchableClientReadHandler [uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #2369:
URL: https://github.com/apache/uniffle/issues/2369#issuecomment-2841002760

   > This is fixed by [#2368](https://github.com/apache/uniffle/pull/2368)
   
   NOop. This is caused by the multi thread writing processedBlockId var


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [I] [Bug] Race condition when using the prefetchableClientReadHandler [uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed issue #2369: [Bug] Race condition when using the prefetchableClientReadHandler
URL: https://github.com/apache/uniffle/issues/2369


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org