[GitHub] rafaelweingartner edited a comment on issue #3131: Working with ACL List Rules in VPC networks

[GitBox <gi...@apache.org>]

rafaelweingartner edited a comment on issue #3131: Working with ACL List Rules in VPC networks
URL: https://github.com/apache/cloudstack/pull/3131#issuecomment-454517717
 
 
   @raiciks this PR is quite odd. The commits are from 2013!
   Moreover, these features were already addressed. I suspect this is coming from CloudPlatform from Accelerite. 
   
   
   >  It is necessary that the names of fields could be active for sorting - Ascending / Descending functionality;
   
   Rules are ordered by `#Rule`. Therefore, order method for sorting might confuse users in this screen. 
   
   > It is necessary for customers to offer filtering of Traffic Type. Customer would be very happy if they can choose to view only Ingress or Egress rules.
   
   That is a great idea, but I am not seeing any Javascript files being changed here. We only need to add some Javascript code to add this feature.
   
   > If customer have huge list of ACL rules, than bottom scrollbar is not visible if you are in top or middle of ACL rules list. This is troublesome in daily administrating tasks.
   
   This has already been fixed with PR https://github.com/apache/cloudstack/pull/2456
   
   I will close this PR, as it does not seem to bring new feature or values. It does provide an interesting idea regarding ACL items being listed, but I am not seeing any code to enable such feature.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services