[GitHub] [iceberg] danielcweeks commented on a diff in pull request #5289: AWS: Reduce TestS3FileIO prefix test scale factors. Replace with S3FileIO integration tests.

[GitBox <gi...@apache.org>]

danielcweeks commented on code in PR #5289:
URL: https://github.com/apache/iceberg/pull/5289#discussion_r924717267


##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -217,9 +218,9 @@ public void testPrefixList() {
   @Test
   public void testPrefixDelete() {
     String prefix = "s3://bucket/path/to/delete";
-    List<Integer> scaleSizes = Lists.newArrayList(0, 5, 1000, 2500);
+    List<Integer> scaleSizes = Lists.newArrayList(0, 5, 1000);

Review Comment:
   Can we make the third scale `1001`?  That will actually trigger a single pagination, which would be good to include at minor additional overhead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org